editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java - Issue 25509003: It is statically OK to call methods on bottom type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java

Issue 25509003: It is statically OK to call methods on bottom type. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java

index db60d53a9e3db598d85c37c8d4f39d1fd8f189ad..e3251504e7be6fceecb123a821fea7efcb90c95d 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java

@@ -78,7 +78,6 @@ import com.google.dart.engine.element.VariableElement;

import com.google.dart.engine.error.AnalysisError;

import com.google.dart.engine.error.AnalysisErrorListener;

import com.google.dart.engine.error.ErrorCode;

-import com.google.dart.engine.internal.type.BottomTypeImpl;

import com.google.dart.engine.scanner.Token;

import com.google.dart.engine.scanner.TokenType;

import com.google.dart.engine.source.Source;

@@ -798,7 +797,7 @@ public class ResolverVisitor extends ScopedVisitor {

* @param potentialType the potential type of the element

protected void override(VariableElement element, Type potentialType) {

- if (potentialType == null || potentialType == BottomTypeImpl.getInstance()) {

+ if (potentialType == null || potentialType.isBottom()) {

return;

}

if (element instanceof PropertyInducingElement) {