editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java - Issue 25509003: It is statically OK to call methods on bottom type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java

Issue 25509003: It is statically OK to call methods on bottom type. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java

diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java

index acbe7c86a429f173917cce0e0366586619b86f41..687ff7546a9b158f12ee2c60e85ebe3c9d8b4551 100644

--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java

+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java

@@ -56,8 +56,6 @@ import com.google.dart.engine.element.CompilationUnitElement;

import com.google.dart.engine.element.Element;

import com.google.dart.engine.element.LibraryElement;

import com.google.dart.engine.formatter.edit.Edit;

-import com.google.dart.engine.internal.type.BottomTypeImpl;

-import com.google.dart.engine.internal.type.DynamicTypeImpl;

import com.google.dart.engine.scanner.Keyword;

import com.google.dart.engine.scanner.KeywordToken;

import com.google.dart.engine.scanner.TokenClass;

@@ -303,8 +301,7 @@ public class QuickAssistProcessorImpl implements QuickAssistProcessor {

}

Type type = value.getStaticType();

// check type

- if (type == null || type == DynamicTypeImpl.getInstance()

- || type == BottomTypeImpl.getInstance()) {

+ if (type == null || type.isDynamic() || type.isBottom()) {

return;

}

// add edit