editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java - Issue 25509003: It is statically OK to call methods on bottom type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

Issue 25509003: It is statically OK to call methods on bottom type. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/Type.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

index 35c58fe5a3335ab06427e341f39810b72292f4e3..9f68a8b2a405fd96b25a9cee1e06f6238e797527 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

@@ -128,7 +128,6 @@ import com.google.dart.engine.internal.resolver.InheritanceManager;

import com.google.dart.engine.internal.resolver.TypeProvider;

import com.google.dart.engine.internal.scope.Namespace;

import com.google.dart.engine.internal.scope.NamespaceBuilder;

-import com.google.dart.engine.internal.type.BottomTypeImpl;

import com.google.dart.engine.internal.type.DynamicTypeImpl;

import com.google.dart.engine.internal.type.VoidTypeImpl;

import com.google.dart.engine.parser.ParserErrorCode;

@@ -4368,8 +4367,7 @@ public class ErrorVerifier extends RecursiveASTVisitor<Void> {

private boolean checkForReturnOfInvalidType(Expression returnExpression, Type expectedReturnType) {

Type staticReturnType = getStaticType(returnExpression);

if (expectedReturnType.isVoid()) {

- if (staticReturnType.isVoid() || staticReturnType.isDynamic()

- || staticReturnType == BottomTypeImpl.getInstance()) {

+ if (staticReturnType.isVoid() || staticReturnType.isDynamic() || staticReturnType.isBottom()) {

return false;

}

errorReporter.reportError(

@@ -4989,7 +4987,7 @@ public class ErrorVerifier extends RecursiveASTVisitor<Void> {

}

private boolean isFunctionType(Type type) {

- if (type.isDynamic() || type == BottomTypeImpl.getInstance()) {

+ if (type.isDynamic() || type.isBottom()) {

return true;

} else if (type instanceof FunctionType || type.isDartCoreFunction()) {

return true;