Issue 253623003: Enables all startup code for arm64.

Issue 253623003: Enables all startup code for arm64. (Closed)

Created:
6 years, 8 months ago by zra

Modified:
6 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enables all startup code for arm64. Also, enables a few more codegen tests, and adds a conditional move instruction. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35440

Patch Set 4 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+983 lines, -157 lines)			Patch
M	runtime/vm/assembler_arm64.h	View	1 2 3	17 chunks	+57 lines, -14 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1 2 3	9 chunks	+70 lines, -8 lines	0 comments	Download
M	runtime/vm/assembler_arm64_test.cc	View	1 2 3	2 chunks	+32 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator_test.cc	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View	1 2 3	4 chunks	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/dart.cc	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View	1 2 3	3 chunks	+16 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1 2 3	3 chunks	+31 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 2 3	6 chunks	+212 lines, -24 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View	1 2 3	5 chunks	+74 lines, -74 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1 2 3	8 chunks	+52 lines, -7 lines	0 comments	Download
M	runtime/vm/stack_frame_arm64.h	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 2 3	6 chunks	+419 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

Sorry this got a bit long. I kept hitting more and more unimplemented instructions and ...

6 years, 8 months ago (2014-04-25 15:58:58 UTC) #1

regis

LGTM https://codereview.chromium.org/253623003/diff/20001/runtime/vm/assembler_arm64.h File runtime/vm/assembler_arm64.h (right): https://codereview.chromium.org/253623003/diff/20001/runtime/vm/assembler_arm64.h#newcode1054 runtime/vm/assembler_arm64.h:1054: ASSERT((sz == kDoubleWord) || (sz == kWord)); Should ...

6 years, 8 months ago (2014-04-25 18:39:04 UTC) #2

zra

Thanks! https://codereview.chromium.org/253623003/diff/20001/runtime/vm/assembler_arm64.h File runtime/vm/assembler_arm64.h (right): https://codereview.chromium.org/253623003/diff/20001/runtime/vm/assembler_arm64.h#newcode1054 runtime/vm/assembler_arm64.h:1054: ASSERT((sz == kDoubleWord) || (sz == kWord)); On ...

6 years, 8 months ago (2014-04-25 18:54:23 UTC) #3

zra

6 years, 8 months ago (2014-04-25 18:54:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r35440 (presubmit successful).

Expand Messages | Collapse Messages