update build to modify 64 bit DartEditor.ini

update build to modify 64 bit DartEditor.ini
This modifies the 64 bit DartEditor.ini files to increase the starting and maximum memory
BUG=dartbug.com/13580
R=devoncarew@google.com, ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27967

[danrubel, 2013-09-26 03:54:12]

I've tried this on Linux and Mac, but not Windows.

[devoncarew, 2013-09-26 16:05:34]

lgtm

[ricow1, 2013-09-26 17:35:40]

LGTM - I am not sure this will work on windows.
The build.py changes are pretty hackish, but we will be retiring that soon so I
guess it is fine

https://codereview.chromium.org/24596007/diff/2001/editor/build/build.py
File editor/build/build.py (right):

https://codereview.chromium.org/24596007/diff/2001/editor/build/build.py#newc...
editor/build/build.py:874: inifile = join('dart', 'DartEditor.app', 'Contents',
'MacOS', 'DartEditor.ini')
long line

https://codereview.chromium.org/24596007/diff/2001/editor/build/build.py#newc...
editor/build/build.py:882: else:
why do we do it differently on windows and mac

https://codereview.chromium.org/24596007/diff/2001/tools/create_editor.py
File tools/create_editor.py (right):

https://codereview.chromium.org/24596007/diff/2001/tools/create_editor.py#new...
tools/create_editor.py:65: inifile = join(tempDir, 'dart', 'DartEditor.app',
'Contents', 'MacOS', 'DartEditor.ini')
long line

https://codereview.chromium.org/24596007/diff/2001/tools/create_editor.py#new...
tools/create_editor.py:77: def Modify64BitDartEditorIni(iniFilePath):
You could make this slightly more generic in case we want to do other edits in
the future, e.g., have a map from configurations to regexps that we would run on
the lines. I will not hold it against you if you keep this though.

[danrubel, 2013-09-26 18:28:45]

https://codereview.chromium.org/24596007/diff/2001/editor/build/build.py
File editor/build/build.py (right):

https://codereview.chromium.org/24596007/diff/2001/editor/build/build.py#newc...
editor/build/build.py:874: inifile = join('dart', 'DartEditor.app', 'Contents',
'MacOS', 'DartEditor.ini')
On 2013/09/26 17:35:40, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/24596007/diff/2001/editor/build/build.py#newc...
editor/build/build.py:882: else:
On 2013/09/26 17:35:40, ricow1 wrote:
> why do we do it differently on windows and mac

I am following what's been done before in tools/create_editor.py.
I'm happy to change it if there is some one way that works everywhere.

https://codereview.chromium.org/24596007/diff/2001/tools/create_editor.py
File tools/create_editor.py (right):

https://codereview.chromium.org/24596007/diff/2001/tools/create_editor.py#new...
tools/create_editor.py:65: inifile = join(tempDir, 'dart', 'DartEditor.app',
'Contents', 'MacOS', 'DartEditor.ini')
On 2013/09/26 17:35:40, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/24596007/diff/2001/tools/create_editor.py#new...
tools/create_editor.py:77: def Modify64BitDartEditorIni(iniFilePath):
On 2013/09/26 17:35:40, ricow1 wrote:
> You could make this slightly more generic in case we want to do other edits in
> the future, e.g., have a map from configurations to regexps that we would run
on
> the lines. I will not hold it against you if you keep this though.

Good idea for a future CL.

[danrubel, 2013-09-26 18:31:13]

Committed patchset #3 manually as r27967 (presubmit successful).