Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: editor/build/build.py

Issue 24596007: update build to modify 64 bit DartEditor.ini (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/create_editor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/build/build.py
diff --git a/editor/build/build.py b/editor/build/build.py
index 7fa227834007297c27a8959d9dec11c73c47b39b..0b2ffa2df26a43d76623099e3791260e493fb6ac 100755
--- a/editor/build/build.py
+++ b/editor/build/build.py
@@ -868,6 +868,33 @@ def PostProcessEditorBuilds(out_dir):
print(' processing %s' % basename)
+ # adjust memory params for 64 bit versions
+ if (basename.endswith('-64.zip')):
+ if (basename.startswith('darteditor-macos-')):
+ inifile = join('dart', 'DartEditor.app', 'Contents', 'MacOS',
+ 'DartEditor.ini')
+ else:
+ inifile = join('dart', 'DartEditor.ini')
+
+ if (basename.startswith('darteditor-win32-')):
+ f = zipfile.ZipFile(zipFile)
+ f.extract(inifile)
+ f.close()
+ else:
+ subprocess.call(['unzip', zipFile, inifile], env=os.environ)
+
+ Modify64BitDartEditorIni(inifile)
+
+ if (basename.startswith('darteditor-win32-')):
+ f = zipfile.ZipFile(zipFile)
+ f.write(inifile)
+ f.close()
+ else:
+ subprocess.call(['zip', '-d', zipFile, inifile], env=os.environ)
+ subprocess.call(['zip', '-q', zipFile, inifile], env=os.environ)
+
+ os.remove(inifile)
+
# post-process the info.plist file
if (basename.startswith('darteditor-macos-')):
infofile = join('dart', 'DartEditor.app', 'Contents', 'Info.plist')
@@ -880,6 +907,17 @@ def PostProcessEditorBuilds(out_dir):
os.remove(infofile)
+def Modify64BitDartEditorIni(iniFilePath):
+ f = open(iniFilePath, 'r')
+ lines = f.readlines()
+ f.close()
+ lines[lines.index('-Xms40m\n')] = '-Xms256m\n'
+ lines[lines.index('-Xmx1000m\n')] = '-Xmx2000m\n'
+ f = open(iniFilePath, 'w')
+ f.writelines(lines);
+ f.close()
+
+
def RunEditorTests(buildout, buildos):
StartBuildStep('run_tests')
« no previous file with comments | « no previous file | tools/create_editor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698