update build to modify 64 bit DartEditor.ini

tools/create_editor.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 #
 # A script which will be invoked from gyp to create a build of the editor.
 #
 # Usage: ./tools/create_editor.py
 #            [--mode <mode>] [--arch <arch>] [--out <output>] [--build <build>]
@@ skipping 27 matching lines @@
 }
 
 def AntPath():
   parent = join('third_party', 'apache_ant', '1.8.4', 'bin')
   if utils.IsWindows():
     return join(parent, 'ant.bat')
   else:
     return join(parent, 'ant')
 
 
-def ProcessEditorArchive(archive, outDir):
+def ProcessEditorArchive(arch, archive, outDir):
   tempDir = join(GetEditorTemp(), 'editor.out')
   try:
     os.makedirs(tempDir)
   except OSError:
     # Directory already exists.
     pass
 
   if utils.IsWindows():
     f = zipfile.ZipFile(archive)
     f.extractall(tempDir)
     f.close()
   else:
     subprocess.call(['unzip', '-q', archive, '-d', tempDir])
 
+  if arch == 'x64':
+    if utils.GuessOS() == 'macos':
+      inifile = join(tempDir, 'dart', 'DartEditor.app', 'Contents', 'MacOS', 'DartEditor.ini')

[ricow1, 2013/09/26 17:35:40]

long line

[danrubel, 2013/09/26 18:28:45]

Done.

+    else:
+      inifile = join(tempDir, 'dart', 'DartEditor.ini')
+    Modify64BitDartEditorIni(inifile)
+
   for src in glob.glob(join(tempDir, 'dart', '*')):
     shutil.move(src, outDir)
 
   shutil.rmtree(tempDir)
   os.unlink(archive)
 
 
+def Modify64BitDartEditorIni(iniFilePath):

[ricow1, 2013/09/26 17:35:40]

You could make this slightly more generic in case we want to do other edits in
the future, e.g., have a map from configurations to regexps that we would run on
the lines. I will not hold it against you if you keep this though.

[danrubel, 2013/09/26 18:28:45]

Good idea for a future CL.

+  f = open(iniFilePath, 'r')
+  lines = f.readlines()
+  f.close()
+  lines[lines.index('-Xms40m\n')] = '-Xms256m\n'
+  lines[lines.index('-Xmx1000m\n')] = '-Xmx2000m\n'
+  f = open(iniFilePath, 'w')
+  f.writelines(lines);
+  f.close()
+
+
 def GetEditorTemp():
   return join(BUILD, 'editor.build.temp')
 
 
 def GetDownloadCache():
   return GetEclipseBuildRoot()
 
 
 def GetEclipseBuildRoot():
   return join(BUILD, 'editor.build.cache')
@@ skipping 101 matching lines @@
   if buildRcpStatus != 0:
     sys.exit(buildRcpStatus)
 
   # build_rcp.xml will put the built editor archive in the OUTPUT directory
   # (dart-editor-macosx.cocoa.x86.zip). It contains the editor application in a
   # dart/ subdirectory. We unzip the contents of the archive into OUTPUT. It
   # will use the ../dart-sdk directory as its SDK.
   archives = glob.glob(join(OUTPUT, '*.zip'))
 
   if archives:
-    ProcessEditorArchive(archives[0], OUTPUT)
+    ProcessEditorArchive(arch, archives[0], OUTPUT)
 
   if os.path.exists(GetEditorTemp()):
     shutil.rmtree(GetEditorTemp())
 
   print('\nEditor build successful')
 
 
 if __name__ == '__main__':
   sys.exit(Main())