update build to modify 64 bit DartEditor.ini

editor/build/build.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import glob
 import gsutil
 import imp
 import optparse
@@ skipping 850 matching lines @@
 
 
 def PostProcessEditorBuilds(out_dir):
   """Post-process the created RCP builds"""
 
   for zipFile in _FindRcpZipFiles(out_dir):
     basename = os.path.basename(zipFile)
 
     print('  processing %s' % basename)
 
+    # adjust memory params for 64 bit versions
+    if (basename.endswith('-64.zip')):
+      if (basename.startswith('darteditor-macos-')):
+        inifile = join('dart', 'DartEditor.app', 'Contents', 'MacOS', 'DartEditor.ini')

[ricow1, 2013/09/26 17:35:40]

long line

[danrubel, 2013/09/26 18:28:45]

Done.

+      else:
+        inifile = join('dart', 'DartEditor.ini')
+
+      if (basename.startswith('darteditor-win32-')):
+        f = zipfile.ZipFile(zipFile)
+        f.extract(inifile)
+        f.close()
+      else:

[ricow1, 2013/09/26 17:35:40]

why do we do it differently on windows and mac

[danrubel, 2013/09/26 18:28:45]

I am following what's been done before in tools/create_editor.py.
I'm happy to change it if there is some one way that works everywhere.

+        subprocess.call(['unzip', zipFile, inifile], env=os.environ)
+
+      Modify64BitDartEditorIni(inifile)
+
+      if (basename.startswith('darteditor-win32-')):
+        f = zipfile.ZipFile(zipFile)
+        f.write(inifile)
+        f.close()
+      else:
+        subprocess.call(['zip', '-d', zipFile, inifile], env=os.environ)
+        subprocess.call(['zip', '-q', zipFile, inifile], env=os.environ)
+
+      os.remove(inifile)
+
     # post-process the info.plist file
     if (basename.startswith('darteditor-macos-')):
       infofile = join('dart', 'DartEditor.app', 'Contents', 'Info.plist')
       subprocess.call(['unzip', zipFile, infofile], env=os.environ)
       ReplaceInFiles(
           [infofile],
           [('<dict>',
             '<dict>\n\t<key>NSHighResolutionCapable</key>\n\t\t<true/>')])
       subprocess.call(['zip', '-q', zipFile, infofile], env=os.environ)
       os.remove(infofile)
 
 
+def Modify64BitDartEditorIni(iniFilePath):
+  f = open(iniFilePath, 'r')
+  lines = f.readlines()
+  f.close()
+  lines[lines.index('-Xms40m\n')] = '-Xms256m\n'
+  lines[lines.index('-Xmx1000m\n')] = '-Xmx2000m\n'
+  f = open(iniFilePath, 'w')
+  f.writelines(lines);
+  f.close()
+
+
 def RunEditorTests(buildout, buildos):
   StartBuildStep('run_tests')
 
   for editorArchive in _GetTestableRcpArchives(buildout):
     with utils.TempDir('editor_') as tempDir:
       print 'Running tests for %s...' % editorArchive
 
       zipper = ziputils.ZipUtil(join(buildout, editorArchive), buildos)
       zipper.UnZip(tempDir)
 
@@ skipping 329 matching lines @@
   """delete the given file - do not re-throw any exceptions that occur"""
   if os.path.exists(f):
     try:
       os.remove(f)
     except OSError:
       print 'error deleting %s' % f
 
 
 if __name__ == '__main__':
   sys.exit(main())