Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22854024: Rename Identifier.getElement (Closed)

Created:
7 years, 4 months ago by Brian Wilkerson
Modified:
7 years, 4 months ago
Reviewers:
jwren, messick, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename Identifier.getElement. Prior to this change the method getElement() was semantically equivalent to getBestElement(), but that was rarely the correct method to be using. I have divided it into getBestElement() and getPropagatedElement(), but in most cases replaced its use with getStaticElement(). Please check this carefully. Although all of the tests pass, there's still a possibility that I translated something wrong at some point (especially in code outside engine) and I'd like to catch any mistakes as early as possible. R=jwren@google.com, messick@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=26380

Patch Set 1 #

Patch Set 2 : re-upload #

Patch Set 3 : clean-up and fix #

Total comments: 18
Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -354 lines) Patch
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java View 5 chunks +6 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/CorrectionUtils.java View 4 chunks +4 lines, -4 lines 2 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickFixProcessorImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ExtractExpressionAnalyzer.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/ExtractMethodAnalyzer.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/InlineLocalRefactoringImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/InlineMethodRefactoringImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/util/NameOccurrencesFinder.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/internal/correction/CorrectionUtilsTest.java View 9 chunks +9 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/Annotation.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/ClassDeclaration.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/ClassTypeAlias.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/DeclaredIdentifier.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FormalParameter.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FunctionDeclaration.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/FunctionTypeAlias.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/Identifier.java View 2 chunks +16 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/LibraryIdentifier.java View 3 chunks +10 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/MethodDeclaration.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/NamedExpression.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/PrefixedIdentifier.java View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/SimpleIdentifier.java View 3 chunks +10 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/TypeParameter.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/VariableDeclaration.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/ElementLocator.java View 5 chunks +6 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java View 23 chunks +24 lines, -24 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java View 5 chunks +6 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ReferenceFinder.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/ResolutionEraser.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/hint/ImportsVerifier.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/IndexContributor.java View 8 chunks +9 lines, -8 lines 4 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java View 5 chunks +6 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java View 31 chunks +40 lines, -76 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java View 6 chunks +51 lines, -18 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java View 3 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java View 11 chunks +13 lines, -16 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java View 11 chunks +14 lines, -15 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 16 chunks +17 lines, -17 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/ast/ASTFactory.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/builder/ElementBuilderTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantFinderTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ReferenceFinderTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/context/AnalysisContextImplTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/index/AbstractDartTest.java View 2 chunks +2 lines, -2 lines 4 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/index/IndexContributorTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/ElementResolverTest.java View 19 chunks +28 lines, -28 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/ResolutionVerifier.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzerTest.java View 9 chunks +10 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/StaticTypeVerifier.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TypeResolverVisitorTest.java View 12 chunks +16 lines, -16 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/TypePropagationTest.java View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/reorg/RenameLinkedMode.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/SemanticHighlightings.java View 13 chunks +13 lines, -13 lines 6 comments Download
M editor/util/plugins/com.google.dart.dev_util/src/com/google/dart/dev/util/ast/ASTExplorer.java View 1 chunk +1 line, -1 line 2 comments Download
M tests/co19/co19-analyzer.status View 2 chunks +0 lines, -4 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/lib/analyzer/analyze_tests.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Brian Wilkerson
7 years, 4 months ago (2013-08-19 21:16:36 UTC) #1
jwren
LGTM! Big cl :) +1 for this effort! https://codereview.chromium.org/22854024/diff/9001/editor/util/plugins/com.google.dart.dev_util/src/com/google/dart/dev/util/ast/ASTExplorer.java File editor/util/plugins/com.google.dart.dev_util/src/com/google/dart/dev/util/ast/ASTExplorer.java (right): https://codereview.chromium.org/22854024/diff/9001/editor/util/plugins/com.google.dart.dev_util/src/com/google/dart/dev/util/ast/ASTExplorer.java#newcode476 editor/util/plugins/com.google.dart.dev_util/src/com/google/dart/dev/util/ast/ASTExplorer.java:476: private ...
7 years, 4 months ago (2013-08-19 21:41:54 UTC) #2
scheglov
lgtm https://codereview.chromium.org/22854024/diff/9001/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/CorrectionUtils.java File editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/CorrectionUtils.java (right): https://codereview.chromium.org/22854024/diff/9001/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/CorrectionUtils.java#newcode520 editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/CorrectionUtils.java:520: Element element = node.getStaticElement(); // TODO(brianwilkerson) Use getBestElement? ...
7 years, 4 months ago (2013-08-19 21:47:02 UTC) #3
messick
lgtm I'm assuming "all tests" includes the completion tests.
7 years, 4 months ago (2013-08-19 21:59:14 UTC) #4
Brian Wilkerson
> I'm assuming "all tests" includes the completion tests. Yes. It includes engine, services, core, ...
7 years, 4 months ago (2013-08-20 18:22:38 UTC) #5
Brian Wilkerson
7 years, 4 months ago (2013-08-20 18:50:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 manually as r26380 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698