editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/InlineMethodRefactoringImpl.java - Issue 22854024: Rename Identifier.getElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/InlineMethodRefactoringImpl.java

Issue 22854024: Rename Identifier.getElement (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: clean-up and fix Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/CorrectionUtils.java ('K') | « editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/InlineLocalRefactoringImpl.java ('k') | editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/util/NameOccurrencesFinder.java » ('j') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/IndexContributor.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/InlineMethodRefactoringImpl.java

diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/InlineMethodRefactoringImpl.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/InlineMethodRefactoringImpl.java

index 51a4f9c104e9632031bca9eaebe940bbad8909a2..d25c6bd528704344a07802bcabec9070bd5cf1f0 100644

--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/InlineMethodRefactoringImpl.java

+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/InlineMethodRefactoringImpl.java

@@ -706,7 +706,7 @@ public class InlineMethodRefactoringImpl extends RefactoringImpl implements Inli

}

if (e instanceof SimpleIdentifier) {

SimpleIdentifier identifier = (SimpleIdentifier) e;

- Element element = identifier.getElement();

+ Element element = identifier.getBestElement();

if (element instanceof VariableElement) {

return false;

}

@@ -757,7 +757,7 @@ public class InlineMethodRefactoringImpl extends RefactoringImpl implements Inli

}

SimpleIdentifier selectedIdentifier = (SimpleIdentifier) selectedNode;

// prepare selected ExecutableElement

- Element selectedElement = selectedIdentifier.getElement();

+ Element selectedElement = selectedIdentifier.getBestElement();

if (!(selectedElement instanceof ExecutableElement)) {

return RefactoringStatus.createFatalErrorStatus("Method declaration or reference must be selected to activate this refactoring.");

}