editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java - Issue 22854024: Rename Identifier.getElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java

Issue 22854024: Rename Identifier.getElement (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: clean-up and fix Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java ('k') | editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/CorrectionUtils.java » ('j') | editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/CorrectionUtils.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java

diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java

index fc7bbbce9fcc7862bffac47848b922daf5987b93..4a464e23a898781c6ec08831d58694b5d993a9a5 100644

--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java

+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/ContextAnalyzer.java

@@ -144,7 +144,7 @@ class ContextAnalyzer extends GeneralizingASTVisitor<Void> {

@Override

public Void visitPrefixedIdentifier(PrefixedIdentifier node) {

if (node == completionNode || node.getIdentifier() == completionNode) {

- Element element = node.getPrefix().getElement();

+ Element element = node.getPrefix().getBestElement();

if (!(element instanceof ClassElement)) {

state.prohibitsStaticReferences();

} else {