Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2650)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java

Issue 22854024: Rename Identifier.getElement (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: clean-up and fix Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java
index a17528243b671b46243c860ddf8777067a1522c8..65c4890146536bfc3abe08eb647e6c013f361277 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java
@@ -173,7 +173,7 @@ public class DeclarationResolver extends RecursiveASTVisitor<Void> {
enclosingExecutable = enclosingClass.getUnnamedConstructor();
} else {
enclosingExecutable = enclosingClass.getNamedConstructor(constructorName.getName());
- constructorName.setElement(enclosingExecutable);
+ constructorName.setStaticElement(enclosingExecutable);
}
node.setElement((ConstructorElement) enclosingExecutable);
return super.visitConstructorDeclaration(node);
@@ -262,7 +262,7 @@ public class DeclarationResolver extends RecursiveASTVisitor<Void> {
PropertyAccessorElement accessor = find(enclosingUnit.getAccessors(), functionName);
if (((KeywordToken) property).getKeyword() == Keyword.SET) {
accessor = accessor.getVariable().getSetter();
- functionName.setElement(accessor);
+ functionName.setStaticElement(accessor);
}
enclosingExecutable = accessor;
}
@@ -364,12 +364,12 @@ public class DeclarationResolver extends RecursiveASTVisitor<Void> {
enclosingClass.getMethods(),
nameOfMethod,
methodName.getOffset());
- methodName.setElement(enclosingExecutable);
+ methodName.setStaticElement(enclosingExecutable);
} else {
PropertyAccessorElement accessor = find(enclosingClass.getAccessors(), methodName);
if (((KeywordToken) property).getKeyword() == Keyword.SET) {
accessor = accessor.getVariable().getSetter();
- methodName.setElement(accessor);
+ methodName.setStaticElement(accessor);
}
enclosingExecutable = accessor;
}
@@ -533,7 +533,7 @@ public class DeclarationResolver extends RecursiveASTVisitor<Void> {
*/
private <E extends Element> E find(E[] elements, SimpleIdentifier identifier) {
E element = find(elements, identifier.getName(), identifier.getOffset());
- identifier.setElement(element);
+ identifier.setStaticElement(element);
return element;
}
@@ -622,6 +622,7 @@ public class DeclarationResolver extends RecursiveASTVisitor<Void> {
}
ParameterElement element = parameters == null ? null : find(parameters, parameterName);
if (element == null) {
+ @SuppressWarnings("resource")
PrintStringWriter writer = new PrintStringWriter();
writer.println("Invalid state found in the Analysis Engine:");
writer.println("DeclarationResolver.getElementForParameter() is visiting a parameter that "

Powered by Google App Engine
This is Rietveld 408576698