Issue 22303002: Auto create ApiLocalScope before calling native functions, this ensures that

Issue 22303002: Auto create ApiLocalScope before calling native functions, this ensures that (Closed)

Created:
7 years, 4 months ago by siva

Modified:
7 years, 4 months ago

Reviewers:
Bill Hesse, Søren Gjesse, regis, srdjan

CC:
reviews_dartlang.org, Anders Johnsen, Søren Thygesen Gjesse

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Auto create ApiLocalScope before calling native functions, this ensures that native functions do not have to call Dart_EnterScope/Dart_ExitScope when they callback into the VM. Remove Dart_EnterScope/Dart_ExitScope calls around native functions in 'bin' directory. R=regis@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25827

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 8

Patch Set 6 : #

Patch Set 7 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+511 lines, -282 lines)			Patch
M	runtime/bin/builtin_natives.cc	View	1 2 3 4 5	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/crypto.cc	View	1 2 3 4 5	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/directory.cc	View	1 2 3 4 5	10 chunks	+0 lines, -18 lines	0 comments	Download
M	runtime/bin/eventhandler.cc	View	1 2 3 4 5	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/file.cc	View	1 2 3 4 5	27 chunks	+0 lines, -58 lines	0 comments	Download
M	runtime/bin/filter.cc	View	1 2 3 4 5	5 chunks	+0 lines, -10 lines	0 comments	Download
M	runtime/bin/filter_unsupported.cc	View	1 2 3 4 5	1 chunk	+0 lines, -10 lines	0 comments	Download
M	runtime/bin/platform.cc	View	1 2 3 4 5	3 chunks	+0 lines, -12 lines	0 comments	Download
M	runtime/bin/process.cc	View	1 2 3 4 5	6 chunks	+0 lines, -16 lines	0 comments	Download
M	runtime/bin/secure_socket.cc	View	1 2 3 4 5	11 chunks	+0 lines, -24 lines	0 comments	Download
M	runtime/bin/secure_socket_unsupported.cc	View	1 2 3 4 5	1 chunk	+0 lines, -26 lines	0 comments	Download
M	runtime/bin/socket.cc	View	1 2 3 4 5	16 chunks	+0 lines, -29 lines	0 comments	Download
M	runtime/bin/stdin.cc	View	1 2 3 4 5	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/ast.h	View	1 2 3 4 5	3 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/benchmark_test.cc	View	1 2 3 4 5	4 chunks	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/bootstrap.h	View	1 2 3 4 5	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.cc	View	1 2 3 4 5	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/code_descriptors_test.cc	View	1 2 3 4 5	3 chunks	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator_test.cc	View	1 2 3 4 5	3 chunks	+21 lines, -15 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3 4 5	1 chunk	+12 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4 5	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2 3 4 5	1 chunk	+12 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4 5	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/native_arguments.h	View	1 2 3 4 5	3 chunks	+21 lines, -1 line	0 comments	Download
M	runtime/vm/native_entry.h	View	1 2 3 4 5	3 chunks	+8 lines, -7 lines	0 comments	Download
M	runtime/vm/native_entry.cc	View	1 2 3 4 5	2 chunks	+51 lines, -2 lines	0 comments	Download
M	runtime/vm/native_entry_test.cc	View	1 2 3 4 5	6 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4 5	3 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_arm.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1 2 3 4 5	3 chunks	+12 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_mips.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1 2 3 4 5	3 chunks	+13 lines, -2 lines	0 comments	Download
M	runtime/vm/stack_frame_test.cc	View	1 2 3 4 5	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2 3 4 5	1 chunk	+86 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4 5	1 chunk	+72 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 2 3 4 5	1 chunk	+97 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3 4 5	2 chunks	+70 lines, -0 lines	0 comments	Download
M	runtime/vm/verifier.h	View	1 2 3 4 5	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/22303002/diff/57001/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/22303002/diff/57001/runtime/vm/intermediate_language_arm.cc#newcode1010 runtime/vm/intermediate_language_arm.cc:1010: } else { For clarity, I would add ...

7 years, 4 months ago (2013-08-06 17:01:21 UTC) #2

srdjan

LGTM https://codereview.chromium.org/22303002/diff/57001/runtime/vm/ast.h File runtime/vm/ast.h (right): https://codereview.chromium.org/22303002/diff/57001/runtime/vm/ast.h#newcode1548 runtime/vm/ast.h:1548: bool is_bootstrap_native_; // Is a bootstrap native method. ...

7 years, 4 months ago (2013-08-06 17:06:28 UTC) #3

siva

Thanks. https://codereview.chromium.org/22303002/diff/57001/runtime/vm/ast.h File runtime/vm/ast.h (right): https://codereview.chromium.org/22303002/diff/57001/runtime/vm/ast.h#newcode1548 runtime/vm/ast.h:1548: bool is_bootstrap_native_; // Is a bootstrap native method. ...

7 years, 4 months ago (2013-08-06 19:04:26 UTC) #4

siva

Committed patchset #7 manually as r25827 (presubmit successful).

7 years, 4 months ago (2013-08-06 19:28:07 UTC) #5

Message was sent while issue was closed.

Nice change, Siva!

Expand Messages | Collapse Messages