runtime/vm/code_descriptors_test.cc - Issue 22303002: Auto create ApiLocalScope before calling native functions, this ensures that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_descriptors_test.cc

Issue 22303002: Auto create ApiLocalScope before calling native functions, this ensures that (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_descriptors_test.cc

===================================================================

--- runtime/vm/code_descriptors_test.cc (revision 25822)

+++ runtime/vm/code_descriptors_test.cc (working copy)

@@ -182,7 +182,6 @@

static void NativeFunc(Dart_NativeArguments args) {

- Dart_EnterScope();

Dart_Handle i = Dart_GetNativeArgument(args, 0);

Dart_Handle k = Dart_GetNativeArgument(args, 1);

int64_t value = -1;

@@ -191,7 +190,6 @@

EXPECT_VALID(Dart_IntegerToInt64(k, &value));

EXPECT_EQ(20, value);

Isolate::Current()->heap()->CollectAllGarbage();

- Dart_ExitScope();

}

@@ -283,4 +281,3 @@

}

} // namespace dart

« no previous file with comments | « runtime/vm/bootstrap_natives.cc ('k') | runtime/vm/code_generator_test.cc » ('j') | no next file with comments »