Auto create ApiLocalScope before calling native functions, this ensures that

runtime/vm/code_generator_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #include "vm/ast.h"
 #include "vm/assembler.h"
 #include "vm/class_finalizer.h"
 #include "vm/code_generator.h"
@@ skipping 204 matching lines @@
   function.set_num_fixed_parameters(num_fixed_params);
   function.SetNumOptionalParameters(num_opt_params, true);
   const String& native_name =
       String::ZoneHandle(Symbols::New("TestSmiSub"));
   NativeFunction native_function =
       reinterpret_cast<NativeFunction>(TestSmiSub);
   node_seq->Add(new ReturnNode(kPos,
                                new NativeBodyNode(kPos,
                                                   function,
                                                   native_name,
-                                                  native_function)));
+                                                  native_function,
+                                                  false)));

[srdjan, 2013/08/06 17:06:28]

Comment what 'false' means. (also on cases below)

[siva, 2013/08/06 19:04:26]

Done.

 }
 
 
 // Tested Dart code:
 //   return dec(5);
 CODEGEN_TEST2_GENERATE(StaticDecCallCodegen, function, test) {
   SequenceNode* node_seq = test->node_sequence();
   ArgumentListNode* arguments = new ArgumentListNode(kPos);
   arguments->Add(new LiteralNode(kPos, Smi::ZoneHandle(Smi::New(5))));
   node_seq->Add(new ReturnNode(kPos,
@@ skipping 159 matching lines @@
     function.SetParameterTypeAt(i, param_type);
   }
   const String& native_name =
       String::ZoneHandle(Symbols::New("TestSmiSum"));
   NativeFunction native_function =
       reinterpret_cast<NativeFunction>(TestSmiSum);
   node_seq->Add(new ReturnNode(kPos,
                                new NativeBodyNode(kPos,
                                                   function,
                                                   native_name,
-                                                  native_function)));
+                                                  native_function,
+                                                  false)));
 }
 
 
 // Tested Dart code, calling function sum declared above:
 //   return sum(1, 3);
 // Optional arguments are not passed and hence are set to their default values.
 CODEGEN_TEST2_GENERATE(StaticSumCallNoOptCodegen, function, test) {
   SequenceNode* node_seq = test->node_sequence();
   ArgumentListNode* arguments = new ArgumentListNode(kPos);
   arguments->Add(new LiteralNode(kPos, Smi::ZoneHandle(Smi::New(1))));
@@ skipping 66 matching lines @@
     function.SetParameterTypeAt(i, param_type);
   }
   const String& native_name =
       String::ZoneHandle(Symbols::New("TestNonNullSmiSum"));
   NativeFunction native_function =
       reinterpret_cast<NativeFunction>(TestNonNullSmiSum);
   node_seq->Add(new ReturnNode(kPos,
                                new NativeBodyNode(kPos,
                                                   function,
                                                   native_name,
-                                                  native_function)));
+                                                  native_function,
+                                                  false)));
 }
 
 
 // Tested Dart code, calling function sum declared above:
 //   return sum(1, null, 3);
 CODEGEN_TEST2_GENERATE(StaticNonNullSumCallCodegen, function, test) {
   SequenceNode* node_seq = test->node_sequence();
   ArgumentListNode* arguments = new ArgumentListNode(kPos);
   arguments->Add(new LiteralNode(kPos, Smi::ZoneHandle(Smi::New(1))));
   arguments->Add(new LiteralNode(kPos, Smi::ZoneHandle()));
@@ skipping 50 matching lines @@
   app_lib ^= libs.At(num_libs - 1);
   ASSERT(!app_lib.IsNull());
   String& ambiguity_error_msg = String::Handle();
   const Class& cls = Class::Handle(
       app_lib.LookupClass(String::Handle(Symbols::New("A")),
                           &ambiguity_error_msg));
   EXPECT_EQ(cls.raw(), result.clazz());  // No ambiguity error expected.
 }
 
 }  // namespace dart