Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: runtime/vm/benchmark_test.cc

Issue 22303002: Auto create ApiLocalScope before calling native functions, this ensures that (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/ast.h ('k') | runtime/vm/bootstrap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/benchmark_test.cc
===================================================================
--- runtime/vm/benchmark_test.cc (revision 25822)
+++ runtime/vm/benchmark_test.cc (working copy)
@@ -106,7 +106,6 @@
// The specific api functions called here are a bit arbitrary. We are
// trying to get a sense of the overhead for using the dart api.
static void UseDartApi(Dart_NativeArguments args) {
- Dart_EnterScope();
int count = Dart_GetNativeArgumentCount(args);
EXPECT_EQ(3, count);
@@ -132,7 +131,6 @@
// Return param + receiver.field.
Dart_SetReturnValue(args, Dart_NewInteger(value1 * receiver_value));
- Dart_ExitScope();
}
@@ -306,7 +304,6 @@
//
static void StackFrame_accessFrame(Dart_NativeArguments args) {
const int kNumIterations = 100;
- Dart_EnterScope();
Code& code = Code::Handle();
Timer timer(true, "LookupDartCode benchmark");
timer.Start();
@@ -327,7 +324,6 @@
timer.Stop();
int64_t elapsed_time = timer.TotalElapsedTime();
Dart_SetReturnValue(args, Dart_NewInteger(elapsed_time));
- Dart_ExitScope();
}
« no previous file with comments | « runtime/vm/ast.h ('k') | runtime/vm/bootstrap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698