Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 216373004: Use shelf handlers in ScheduledServer. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, kevmoo
Visibility:
Public.

Description

Use shelf handlers in ScheduledServer. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=34713

Patch Set 1 #

Total comments: 6

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -422 lines) Patch
M pkg/scheduled_test/CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/scheduled_test/lib/scheduled_server.dart View 3 chunks +25 lines, -27 lines 0 comments Download
M pkg/scheduled_test/lib/src/scheduled_server/handler.dart View 3 chunks +14 lines, -9 lines 0 comments Download
M pkg/scheduled_test/pubspec.yaml View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/scheduled_test/test/scheduled_server_test.dart View 1 4 chunks +137 lines, -240 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart View 3 chunks +8 lines, -9 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/archives_and_uploads_a_package_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/cloud_storage_upload_doesnt_redirect_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/cloud_storage_upload_provides_an_error_test.dart View 2 chunks +5 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/force_publishes_if_tests_are_no_warnings_or_errors_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/force_publishes_if_there_are_warnings_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/package_creation_provides_a_malformed_error_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/package_creation_provides_a_malformed_success_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/package_creation_provides_an_error_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/package_creation_provides_invalid_json_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/package_validation_has_a_warning_and_continues_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/upload_form_provides_an_error_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/upload_form_provides_invalid_json_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/utils.dart View 3 chunks +8 lines, -14 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/utils.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_a_malformed_credentials_authenticates_again_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_a_pre_existing_credentials_does_not_authenticate_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_a_server_rejected_refresh_token_authenticates_again_test.dart View 3 chunks +8 lines, -10 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_an_expired_credentials_refreshes_and_saves_test.dart View 2 chunks +7 lines, -10 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_an_expired_credentials_without_a_refresh_token_authenticates_again_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_no_credentials_authenticates_and_saves_credentials_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_server_rejected_credentials_authenticates_again_test.dart View 2 chunks +7 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/test/pub_uploader_test.dart View 8 chunks +20 lines, -39 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 8 months ago (2014-04-02 03:18:12 UTC) #1
Bob Nystrom
https://codereview.chromium.org/216373004/diff/1/pkg/scheduled_test/test/scheduled_server_test.dart File pkg/scheduled_test/test/scheduled_server_test.dart (right): https://codereview.chromium.org/216373004/diff/1/pkg/scheduled_test/test/scheduled_server_test.dart#newcode68 pkg/scheduled_test/test/scheduled_server_test.dart:68: // Add a task's worth of space to avoid ...
6 years, 8 months ago (2014-04-02 23:55:30 UTC) #2
nweiz
https://codereview.chromium.org/216373004/diff/1/pkg/scheduled_test/test/scheduled_server_test.dart File pkg/scheduled_test/test/scheduled_server_test.dart (right): https://codereview.chromium.org/216373004/diff/1/pkg/scheduled_test/test/scheduled_server_test.dart#newcode68 pkg/scheduled_test/test/scheduled_server_test.dart:68: // Add a task's worth of space to avoid ...
6 years, 8 months ago (2014-04-03 00:34:08 UTC) #3
Bob Nystrom
lgtm
6 years, 8 months ago (2014-04-03 16:46:32 UTC) #4
nweiz
6 years, 8 months ago (2014-04-03 18:24:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r34713 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698