Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: sdk/lib/_internal/pub/test/oauth2/with_a_server_rejected_refresh_token_authenticates_again_test.dart

Issue 216373004: Use shelf handlers in ScheduledServer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/oauth2/with_a_server_rejected_refresh_token_authenticates_again_test.dart
diff --git a/sdk/lib/_internal/pub/test/oauth2/with_a_server_rejected_refresh_token_authenticates_again_test.dart b/sdk/lib/_internal/pub/test/oauth2/with_a_server_rejected_refresh_token_authenticates_again_test.dart
index d4a81d4181bcf53ad7a713fa0b23cafbe608cea3..e36f97dc89188873ced91386d66b9d01d6975726 100644
--- a/sdk/lib/_internal/pub/test/oauth2/with_a_server_rejected_refresh_token_authenticates_again_test.dart
+++ b/sdk/lib/_internal/pub/test/oauth2/with_a_server_rejected_refresh_token_authenticates_again_test.dart
@@ -7,6 +7,7 @@ import 'dart:io';
import 'package:scheduled_test/scheduled_test.dart';
import 'package:scheduled_test/scheduled_server.dart';
+import 'package:shelf/shelf.dart' as shelf;
import '../../lib/src/io.dart';
import '../descriptor.dart' as d;
@@ -31,13 +32,10 @@ main() {
confirmPublish(pub);
server.handle('POST', '/token', (request) {
- return new ByteStream(request).toBytes().then((bytes) {
- var response = request.response;
- response.statusCode = 400;
- response.reasonPhrase = 'Bad request';
- response.headers.contentType = new ContentType("application", "json");
- response.write(JSON.encode({"error": "invalid_request"}));
- response.close();
+ return drainStream(request.read()).then((_) {
+ return new shelf.Response(400,
+ body: JSON.encode({"error": "invalid_request"}),
+ headers: {'content-type': 'application/json'});
});
});
@@ -45,10 +43,10 @@ main() {
authorizePub(pub, server, 'new access token');
server.handle('GET', '/api/packages/versions/new', (request) {
- expect(request.headers.value('authorization'),
- equals('Bearer new access token'));
+ expect(request.headers,
+ containsPair('authorization', 'Bearer new access token'));
- request.response.close();
+ return new shelf.Response(200);
});
pub.kill();

Powered by Google App Engine
This is Rietveld 408576698