sdk/lib/_internal/pub/test/lish/upload_form_provides_an_error_test.dart - Issue 216373004: Use shelf handlers in ScheduledServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/lish/upload_form_provides_an_error_test.dart

Issue 216373004: Use shelf handlers in ScheduledServer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/lish/package_validation_has_a_warning_and_continues_test.dart ('k') | sdk/lib/_internal/pub/test/lish/upload_form_provides_invalid_json_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/lish/upload_form_provides_an_error_test.dart

diff --git a/sdk/lib/_internal/pub/test/lish/upload_form_provides_an_error_test.dart b/sdk/lib/_internal/pub/test/lish/upload_form_provides_an_error_test.dart

index c4f69a04a1ccb5d0f1a2c3557f375fdaef0ad18a..4df0129e3a8322d494757e71c4904562085be0df 100644

--- a/sdk/lib/_internal/pub/test/lish/upload_form_provides_an_error_test.dart

+++ b/sdk/lib/_internal/pub/test/lish/upload_form_provides_an_error_test.dart

@@ -6,6 +6,7 @@ import 'dart:convert';

import 'package:scheduled_test/scheduled_test.dart';

import 'package:scheduled_test/scheduled_server.dart';

+import 'package:shelf/shelf.dart' as shelf;

import '../descriptor.dart' as d;

import '../test_pub.dart';

@@ -22,11 +23,9 @@ main() {

confirmPublish(pub);

server.handle('GET', '/api/packages/versions/new', (request) {

- request.response.statusCode = 400;

- request.response.write(JSON.encode({

+ return new shelf.Response.notFound(JSON.encode({

'error': {'message': 'your request sucked'}

}));

- request.response.close();

});

pub.stderr.expect('your request sucked');