Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart

Issue 216373004: Use shelf handlers in ScheduledServer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart
diff --git a/sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart b/sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart
index 4be7a4a7275d1d1f8fe1c2056137b07752e4ac77..b9ca6bd09e8ec1852e1231e534c7a5059ab27d12 100644
--- a/sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart
+++ b/sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart
@@ -6,6 +6,7 @@ library pub_tests;
import 'package:scheduled_test/scheduled_server.dart';
import 'package:scheduled_test/scheduled_test.dart';
+import 'package:shelf/shelf.dart' as shelf;
import '../descriptor.dart' as d;
import '../test_pub.dart';
@@ -29,7 +30,9 @@ main() {
var pub = startPub(args: [command.name]);
server.handle('GET', '/api/packages/foo', (request) {
- expect(request.headers['Accept'], ['application/vnd.pub.v2+json']);
+ expect(request.headers['accept'],
+ equals('application/vnd.pub.v2+json'));
+ return new shelf.Response(200);
});
pub.kill();
@@ -49,16 +52,12 @@ main() {
var pub = startPub(args: [command.name]);
- server.handle('GET', '/api/packages/foo', (request) {
- request.response.statusCode = 406;
- request.response.close();
- });
+ server.handle('GET', '/api/packages/foo',
+ (request) => new shelf.Response(406));
// TODO(nweiz): this shouldn't request the versions twice (issue 11077).
- server.handle('GET', '/api/packages/foo', (request) {
- request.response.statusCode = 406;
- request.response.close();
- });
+ server.handle('GET', '/api/packages/foo',
+ (request) => new shelf.Response(406));
pub.shouldExit(1);

Powered by Google App Engine
This is Rietveld 408576698