Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 211283004: Support Types in instance-ref/instance-view (Closed)

Created:
6 years, 9 months ago by turnidge
Modified:
6 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Visibility:
Public.

Description

Support Types in instance-ref/instance-view. Refactor JSON printing for all instances to share more code. This allows Types to act like Instances in Observatory. Update the look and feel for the function-view page. Add script info for functions. Update tests. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34435

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : post code review #

Patch Set 5 : gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9480 lines, -8500 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 4 8 chunks +122 lines, -46 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 576 chunks +4378 lines, -4088 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js.map View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 4 8 chunks +122 lines, -46 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 4 576 chunks +4378 lines, -4088 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js.map View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/field_ref.html View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_view.html View 1 2 3 4 2 chunks +100 lines, -40 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_ref.html View 1 2 3 4 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html View 1 2 3 4 2 chunks +15 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/field_ref.html View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/function_view.dart View 1 2 3 4 1 chunk +70 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/function_view.html View 1 2 3 4 2 chunks +100 lines, -40 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_ref.html View 1 4 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_view.html View 1 2 3 4 2 chunks +15 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart View 1 4 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.dart View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 12 chunks +78 lines, -74 lines 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 5 chunks +55 lines, -49 lines 0 comments Download
M runtime/vm/service_test.cc View 1 2 3 4 5 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Cutch
lgtm but look at my fix to the location manager here: https://codereview.chromium.org/205713004/
6 years, 9 months ago (2014-03-25 17:46:56 UTC) #1
turnidge
6 years, 9 months ago (2014-03-25 21:59:22 UTC) #2
Cutch
lgtm with some comments https://codereview.chromium.org/211283004/diff/80001/runtime/bin/vmservice/client/lib/src/elements/function_view.dart File runtime/bin/vmservice/client/lib/src/elements/function_view.dart (right): https://codereview.chromium.org/211283004/diff/80001/runtime/bin/vmservice/client/lib/src/elements/function_view.dart#newcode41 runtime/bin/vmservice/client/lib/src/elements/function_view.dart:41: switch(function['kind']) { Maybe add a ...
6 years, 9 months ago (2014-03-25 23:12:38 UTC) #3
turnidge
https://codereview.chromium.org/211283004/diff/80001/runtime/bin/vmservice/client/lib/src/elements/function_view.dart File runtime/bin/vmservice/client/lib/src/elements/function_view.dart (right): https://codereview.chromium.org/211283004/diff/80001/runtime/bin/vmservice/client/lib/src/elements/function_view.dart#newcode41 runtime/bin/vmservice/client/lib/src/elements/function_view.dart:41: switch(function['kind']) { On 2014/03/25 23:12:38, Cutch wrote: > Maybe ...
6 years, 9 months ago (2014-03-26 17:05:20 UTC) #4
turnidge
6 years, 9 months ago (2014-03-26 17:13:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r34435 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698