runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart - Issue 211283004: Support Types in instance-ref/instance-view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

Issue 211283004: Support Types in instance-ref/instance-view (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/instance_view.html ('k') | runtime/bin/vmservice/client/lib/src/elements/service_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

diff --git a/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart b/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

index b6b92ec4a9c75149b1f3e6eaf34c6d1cff4b1922..3c2363e778dac864948f9367f0372b232a940b78 100644

--- a/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

+++ b/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

@@ -161,6 +161,10 @@ class ObservatoryElement extends PolymerElement {

type == 'Array');

}

+ bool isType(String type) {

+ return (type == 'Type');

+ }

bool isUnexpected(String type) {

return (!['Null',

'Smi',

@@ -173,6 +177,7 @@ class ObservatoryElement extends PolymerElement {

'Instance',

'GrowableObjectArray',

'Array',

+ 'Type',

'Error'].contains(type));

}