Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html

Issue 211283004: Support Types in instance-ref/instance-view (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html
diff --git a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html b/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html
index 6c400ca8fe7553cb036d59b63954152146bd7f2f..8cfdc616b8076909806ad316935b2bbcbc6aa66b 100644
--- a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html
+++ b/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html
@@ -47,7 +47,12 @@
<template if="{{ instance['error'] == null }}">
<div class="content">
<!-- TODO(turnidge): Handle null instances. -->
- <h1>instance of {{ instance['class']['user_name'] }}</h1>
+ <template if="{{ isType(instance.serviceType) }}">
+ <h1>type {{ instance['user_name'] }}</h1>
+ </template>
+ <template if="{{ !isType(instance.serviceType) }}">
+ <h1>instance of {{ instance['class']['user_name'] }}</h1>
+ </template>
<div class="memberList">
<div class="memberItem">
<div class="memberName">class</div>
@@ -66,6 +71,15 @@
<div class="memberName">size</div>
<div class="memberValue">{{ instance['size'] | formatSize }}</div>
</div>
+ <template if="{{ instance['type_class'] != null }}">
+ <div class="memberItem">
+ <div class="memberName">type class</div>
+ <div class="memberValue">
+ <class-ref ref="{{ instance['type_class'] }}">
+ </class-ref>
+ </div>
+ </div>
+ </template>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698