Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/instance_ref.html

Issue 211283004: Support Types in instance-ref/instance-view (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/instance_ref.html
diff --git a/runtime/bin/vmservice/client/lib/src/elements/instance_ref.html b/runtime/bin/vmservice/client/lib/src/elements/instance_ref.html
index 413ece16fc5425dc36d7bfac11845fc956afc7fe..49c13966d9059efcef40e1c79fa2178d0ae3e8df 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/instance_ref.html
+++ b/runtime/bin/vmservice/client/lib/src/elements/instance_ref.html
@@ -19,7 +19,7 @@
font: 400 14px 'Montserrat', sans-serif;
}
</style>
- <div>
+ <span>
<template if="{{ isUnexpected(ref.serviceType) }}">
unexpected reference type &lt;{{ ref.serviceType }}&gt;
</template>
@@ -39,6 +39,10 @@
<a href="{{ url }}">{{ ref['preview'] }}</a>
</template>
+ <template if="{{ (isType(ref.serviceType)) }}">
+ <a href="{{ url }}">{{ ref['user_name'] }}</a>
+ </template>
+
<template if="{{ isClosure(ref.serviceType) }}">
<a href="{{ url }}">
<!-- TODO(turnidge): Switch this to fully-qualified function -->
@@ -79,8 +83,7 @@
</div>
</curly-block>
</template>
-
- </div>
+ </span>
</template>
<script type="application/dart" src="instance_ref.dart"></script>
</polymer-element>

Powered by Google App Engine
This is Rietveld 408576698