Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2099503002: Add a dedicated Result for skipped tests. (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a dedicated Result for skipped tests. This makes it possible for a test to be marked skip based on its runtime behavior rather than being strictly based on its metadata. See #393 and #394 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/e7ee0906f2c7f7c7dc2382517756eecf33e26029

Patch Set 1 #

Total comments: 2

Patch Set 2 : Test skip result rather than metadata. #

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -39 lines) Patch
M doc/json_reporter.md View 4 chunks +13 lines, -4 lines 0 comments Download
M json_reporter.schema.json View 1 chunk +3 lines, -2 lines 0 comments Download
M lib/src/backend/invoker.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/src/backend/state.dart View 3 chunks +27 lines, -0 lines 0 comments Download
M lib/src/frontend/expect_async.dart View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M lib/src/runner/engine.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M lib/src/runner/live_suite_controller.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/runner/reporter/compact.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/reporter/expanded.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/reporter/json.dart View 2 chunks +6 lines, -1 line 0 comments Download
M test/runner/engine_test.dart View 1 chunk +10 lines, -6 lines 0 comments Download
M test/runner/json_reporter_test.dart View 4 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 6 months ago (2016-06-23 22:20:21 UTC) #1
kevmoo
LGTM https://codereview.chromium.org/2099503002/diff/1/lib/src/frontend/expect_async.dart File lib/src/frontend/expect_async.dart (right): https://codereview.chromium.org/2099503002/diff/1/lib/src/frontend/expect_async.dart#newcode8 lib/src/frontend/expect_async.dart:8: import '../backend/state.dart'; Not not used
4 years, 6 months ago (2016-06-23 23:33:49 UTC) #2
nweiz
Code review changes
4 years, 6 months ago (2016-06-23 23:51:16 UTC) #3
nweiz
https://codereview.chromium.org/2099503002/diff/1/lib/src/frontend/expect_async.dart File lib/src/frontend/expect_async.dart (right): https://codereview.chromium.org/2099503002/diff/1/lib/src/frontend/expect_async.dart#newcode8 lib/src/frontend/expect_async.dart:8: import '../backend/state.dart'; On 2016/06/23 23:33:48, kevmoo wrote: > Not ...
4 years, 6 months ago (2016-06-23 23:52:15 UTC) #4
nweiz
4 years, 6 months ago (2016-06-23 23:53:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
e7ee0906f2c7f7c7dc2382517756eecf33e26029 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698