Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: test/runner/engine_test.dart

Issue 2099503002: Add a dedicated Result for skipped tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/reporter/json.dart ('k') | test/runner/json_reporter_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/engine_test.dart
diff --git a/test/runner/engine_test.dart b/test/runner/engine_test.dart
index 2c4994152932409b5e730351b9c768ed04724fd6..f6904d530113d17f23dcd5e07b1255cbbe0d2c8f 100644
--- a/test/runner/engine_test.dart
+++ b/test/runner/engine_test.dart
@@ -172,13 +172,17 @@ void main() {
expect(liveTest, same(engine.liveTests.single));
expect(liveTest.test.name, equals(tests.single.name));
- var first = true;
+ var i = 0;
liveTest.onStateChange.listen(expectAsync((state) {
- expect(state, equals(first
- ? const State(Status.running, Result.success)
- : const State(Status.complete, Result.success)));
- first = false;
- }, count: 2));
+ if (i == 0) {
+ expect(state, equals(const State(Status.running, Result.success)));
+ } else if (i == 1) {
+ expect(state, equals(const State(Status.running, Result.skipped)));
+ } else if (i == 2) {
+ expect(state, equals(const State(Status.complete, Result.skipped)));
+ }
+ i++;
+ }, count: 3));
expect(liveTest.onComplete, completes);
}));
« no previous file with comments | « lib/src/runner/reporter/json.dart ('k') | test/runner/json_reporter_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698