lib/src/runner/reporter/compact.dart - Issue 2099503002: Add a dedicated Result for skipped tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/runner/reporter/compact.dart

Issue 2099503002: Add a dedicated Result for skipped tests. (Closed) Base URL: git@github.com:dart-lang/test@master

Patch Set: Code review changes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/runner/reporter/compact.dart

diff --git a/lib/src/runner/reporter/compact.dart b/lib/src/runner/reporter/compact.dart

index 1cac68a40089a3037cee4c8f3462c9aeedce93e1..45e15340cd991ff58ef6005048590e224df733e9 100644

--- a/lib/src/runner/reporter/compact.dart

+++ b/lib/src/runner/reporter/compact.dart

@@ -212,7 +212,7 @@ class CompactReporter implements Reporter {

void _onStateChange(LiveTest liveTest, State state) {

if (state.status != Status.complete) return;

- if (liveTest.test.metadata.skip &&

+ if (state.result == Result.skipped &&

liveTest.test.metadata.skipReason != null) {

_progressLine(_description(liveTest));

print('');

« no previous file with comments | « lib/src/runner/live_suite_controller.dart ('k') | lib/src/runner/reporter/expanded.dart » ('j') | no next file with comments »