lib/src/frontend/expect_async.dart - Issue 2099503002: Add a dedicated Result for skipped tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/frontend/expect_async.dart

Issue 2099503002: Add a dedicated Result for skipped tests. (Closed) Base URL: git@github.com:dart-lang/test@master

Patch Set: Code review changes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/frontend/expect_async.dart

diff --git a/lib/src/frontend/expect_async.dart b/lib/src/frontend/expect_async.dart

index a95418e8708d4543f91abc28539c46486047da3b..aa4b8b6114efa3d6b8fe71dc61b3eebcdcf6b1a3 100644

--- a/lib/src/frontend/expect_async.dart

+++ b/lib/src/frontend/expect_async.dart

@@ -5,7 +5,6 @@

import 'dart:async';

import '../backend/invoker.dart';

-import '../backend/state.dart';

import 'expect.dart';

/// An object used to detect unpassed arguments.

@@ -170,8 +169,7 @@ class _ExpectedFunction {

// pass it to the invoker anyway.

try {

_actualCalls++;

- if (_invoker.liveTest.isComplete &&

- _invoker.liveTest.state.result == Result.success) {

+ if (_invoker.liveTest.state.shouldBeDone) {

throw 'Callback ${_id}called ($_actualCalls) after test case '

'${_invoker.liveTest.test.name} had already completed.$_reason';

} else if (_maxExpectedCalls >= 0 && _actualCalls > _maxExpectedCalls) {

« no previous file with comments | « lib/src/backend/state.dart ('k') | lib/src/runner/engine.dart » ('j') | no next file with comments »