Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2091173002: Add metadata to messages emitted by live tests. (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add metadata to messages emitted by live tests. This moves the responsibility for printing skip messages to the engine, rather than the reporter. Reporters now just need to choose how to display the messages produced by the engine. This lays the groundwork for #394, since skip messages can now be emitted during the run of a test. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/bf8a455fffdb84097f8ef54c1eef3ce28fc9de78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -79 lines) Patch
M doc/json_reporter.md View 8 chunks +25 lines, -24 lines 0 comments Download
M json_reporter.schema.json View 1 chunk +4 lines, -3 lines 0 comments Download
M lib/src/backend/invoker.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M lib/src/backend/live_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M lib/src/backend/live_test_controller.dart View 4 chunks +11 lines, -9 lines 0 comments Download
A lib/src/backend/message.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M lib/src/runner/engine.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M lib/src/runner/load_suite.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/remote_listener.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M lib/src/runner/reporter/compact.dart View 3 chunks +9 lines, -14 lines 0 comments Download
M lib/src/runner/reporter/expanded.dart View 3 chunks +8 lines, -9 lines 0 comments Download
M lib/src/runner/reporter/json.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M lib/src/runner/runner_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M test/backend/invoker_test.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M test/runner/browser/loader_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M test/runner/compact_reporter_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/runner/json_reporter_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M test/runner/loader_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 6 months ago (2016-06-24 00:49:48 UTC) #1
kevmoo
Maybe highlight this change in the changelog? I'm not sure this will affect intellij and/or ...
4 years, 5 months ago (2016-06-27 18:15:11 UTC) #2
kevmoo
lgtm
4 years, 5 months ago (2016-06-27 18:15:51 UTC) #3
nweiz
4 years, 5 months ago (2016-07-06 20:02:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf8a455fffdb84097f8ef54c1eef3ce28fc9de78 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698