Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: test/runner/json_reporter_test.dart

Issue 2091173002: Add metadata to messages emitted by live tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/compact_reporter_test.dart ('k') | test/runner/loader_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/json_reporter_test.dart
diff --git a/test/runner/json_reporter_test.dart b/test/runner/json_reporter_test.dart
index be155d95ba51b94d0c4bfacbc74cb4176781ad85..068f7e54c6e0968c6a0950c01ac0336f9df3b363 100644
--- a/test/runner/json_reporter_test.dart
+++ b/test/runner/json_reporter_test.dart
@@ -387,8 +387,10 @@ void main() {
_testDone(1, hidden: true),
_group(2, testCount: 2),
_testStart(3, "skip 1", skip: "some reason", line: 6, column: 9),
+ _print(3, "Skip: some reason", type: "skip"),
_testDone(3, skipped: true),
_testStart(4, "skip 2", skip: "or another", line: 7, column: 9),
+ _print(4, "Skip: or another", type: "skip"),
_testDone(4, skipped: true),
_done()
]);
@@ -602,11 +604,12 @@ Map _testStart(int id, String name, {int suiteID, Iterable<int> groupIDs,
/// Returns the event emitted by the JSON reporter indicating that a test
/// printed [message].
-Map _print(int id, String message) {
+Map _print(int id, String message, {String type}) {
return {
"type": "print",
"testID": id,
- "message": message
+ "message": message,
+ "messageType": type ?? "print"
};
}
« no previous file with comments | « test/runner/compact_reporter_test.dart ('k') | test/runner/loader_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698