Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: lib/src/runner/reporter/expanded.dart

Issue 2091173002: Add metadata to messages emitted by live tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/reporter/compact.dart ('k') | lib/src/runner/reporter/json.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/reporter/expanded.dart
diff --git a/lib/src/runner/reporter/expanded.dart b/lib/src/runner/reporter/expanded.dart
index 21d7c612f6ed134bf9a1f3190407b5a034f6ca97..9220cd87275ff8008ab2af39eb4ed3cd9928baca 100644
--- a/lib/src/runner/reporter/expanded.dart
+++ b/lib/src/runner/reporter/expanded.dart
@@ -6,6 +6,7 @@ import 'dart:async';
import 'dart:isolate';
import '../../backend/live_test.dart';
+import '../../backend/message.dart';
import '../../backend/state.dart';
import '../../utils.dart';
import '../engine.dart';
@@ -184,9 +185,11 @@ class ExpandedReporter implements Reporter {
_subscriptions.add(liveTest.onError.listen((error) =>
_onError(liveTest, error.error, error.stackTrace)));
- _subscriptions.add(liveTest.onPrint.listen((line) {
+ _subscriptions.add(liveTest.onMessage.listen((message) {
_progressLine(_description(liveTest));
- print(line);
+ var text = message.text;
+ if (message.type == MessageType.skip) text = ' $_yellow$text$_noColor';
+ print(text);
}));
}
@@ -194,13 +197,9 @@ class ExpandedReporter implements Reporter {
void _onStateChange(LiveTest liveTest, State state) {
if (state.status != Status.complete) return;
- if (state.result == Result.skipped &&
- liveTest.test.metadata.skipReason != null) {
- print(indent('${_yellow}Skip: ${liveTest.test.metadata.skipReason}'
- '$_noColor'));
- } else if (_engine.active.isNotEmpty) {
- // If any tests are running, display the name of the oldest active
- // test.
+ // If any tests are running, display the name of the oldest active
+ // test.
+ if (_engine.active.isNotEmpty) {
_progressLine(_description(_engine.active.first));
}
}
« no previous file with comments | « lib/src/runner/reporter/compact.dart ('k') | lib/src/runner/reporter/json.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698