Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: lib/src/runner/engine.dart

Issue 2091173002: Add metadata to messages emitted by live tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/backend/message.dart ('k') | lib/src/runner/load_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/engine.dart
diff --git a/lib/src/runner/engine.dart b/lib/src/runner/engine.dart
index e422681c57602fa19a17057e318a78e9b775c3bf..2f3971c9fdc3b27bbb813c2d4b6ec1eff5086b9a 100644
--- a/lib/src/runner/engine.dart
+++ b/lib/src/runner/engine.dart
@@ -14,6 +14,7 @@ import '../backend/group_entry.dart';
import '../backend/invoker.dart';
import '../backend/live_test.dart';
import '../backend/live_test_controller.dart';
+import '../backend/message.dart';
import '../backend/state.dart';
import '../backend/test.dart';
import '../util/iterable_set.dart';
@@ -372,6 +373,12 @@ class Engine {
suiteController.liveSuite.suite, test, () {
controller.setState(const State(Status.running, Result.success));
controller.setState(const State(Status.running, Result.skipped));
+
+ if (entry.metadata.skipReason != null) {
+ controller.message(
+ new Message.skip("Skip: ${entry.metadata.skipReason}"));
+ }
+
controller.setState(const State(Status.complete, Result.skipped));
controller.completer.complete();
}, () {}, groups: parents);
« no previous file with comments | « lib/src/backend/message.dart ('k') | lib/src/runner/load_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698