Track Source objects in PackageNames.

Track Source objects in PackageNames.

This allows PackageName equality to include description equality, and it
substantially cleans up other logic dealing with sources.

See #912

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/07397054bf0cfe269f3c47ae5d78c056dd41b0d7

[Bob Nystrom, 2016-06-23 20:29:49]

https://codereview.chromium.org/2079303003/diff/1/lib/src/package.dart
File lib/src/package.dart (right):

https://codereview.chromium.org/2079303003/diff/1/lib/src/package.dart#newcod...
lib/src/package.dart:489: bool allowsID(PackageId id) =>
Can this just be "allows"? We don't usually mention the parameter type in the
method name unless needed to disambiguate.

https://codereview.chromium.org/2079303003/diff/1/lib/src/source.dart
File lib/src/source.dart (right):

https://codereview.chromium.org/2079303003/diff/1/lib/src/source.dart#newcode197
lib/src/source.dart:197: throw new ArgumentError("Package $id does not use
source ${source.name}.");
While you're here: long line.

https://codereview.chromium.org/2079303003/diff/1/test/version_solver_test.dart
File test/version_solver_test.dart (right):

https://codereview.chromium.org/2079303003/diff/1/test/version_solver_test.da...
test/version_solver_test.dart:656: 'a-x': '1.0.0',
Why the change here?

[nweiz, 2016-06-23 21:01:16]

Code review changes

[nweiz, 2016-06-23 21:01:21]

https://codereview.chromium.org/2079303003/diff/1/lib/src/package.dart
File lib/src/package.dart (right):

https://codereview.chromium.org/2079303003/diff/1/lib/src/package.dart#newcod...
lib/src/package.dart:489: bool allowsID(PackageId id) =>
On 2016/06/23 20:29:49, Bob Nystrom wrote:
> Can this just be "allows"? We don't usually mention the parameter type in the
> method name unless needed to disambiguate.

Done.

https://codereview.chromium.org/2079303003/diff/1/lib/src/source.dart
File lib/src/source.dart (right):

https://codereview.chromium.org/2079303003/diff/1/lib/src/source.dart#newcode197
lib/src/source.dart:197: throw new ArgumentError("Package $id does not use
source ${source.name}.");
On 2016/06/23 20:29:49, Bob Nystrom wrote:
> While you're here: long line.

Done.

https://codereview.chromium.org/2079303003/diff/1/test/version_solver_test.dart
File test/version_solver_test.dart (right):

https://codereview.chromium.org/2079303003/diff/1/test/version_solver_test.da...
test/version_solver_test.dart:656: 'a-x': '1.0.0',
On 2016/06/23 20:29:49, Bob Nystrom wrote:
> Why the change here?

Previously, the result wasn't validating which "a 1.0.0" was selected; it could
have been the one with description "x" or the one with description "y". They
were ==-identical so the test didn't care.

Now that == cares about descriptions, we need to be explicit about which one is
selected. It also makes the test more accurate too.

[Bob Nystrom, 2016-06-23 22:02:20]

LGTM!

https://codereview.chromium.org/2079303003/diff/1/test/version_solver_test.dart
File test/version_solver_test.dart (right):

https://codereview.chromium.org/2079303003/diff/1/test/version_solver_test.da...
test/version_solver_test.dart:656: 'a-x': '1.0.0',
On 2016/06/23 21:01:21, nweiz wrote:
> On 2016/06/23 20:29:49, Bob Nystrom wrote:
> > Why the change here?
> 
> Previously, the result wasn't validating which "a 1.0.0" was selected; it
could
> have been the one with description "x" or the one with description "y". They
> were ==-identical so the test didn't care.
> 
> Now that == cares about descriptions, we need to be explicit about which one
is
> selected. It also makes the test more accurate too.

Ah, cool. I thought it was actually producing a different result.

[nweiz, 2016-06-23 22:04:26]

Description was changed from

==========
Track Source objects in PackageNames.

This allows PackageName equality to include description equality, and it
substantially cleans up other logic dealing with sources.

See #912

R=rnystrom@google.com
==========

to

==========
Track Source objects in PackageNames.

This allows PackageName equality to include description equality, and it
substantially cleans up other logic dealing with sources.

See #912

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/pub/commit/07397054bf0cfe269f3c47ae5d78c056dd41b0d7
==========

[nweiz, 2016-06-23 22:04:28]

Committed patchset #2 (id:20001) manually as
07397054bf0cfe269f3c47ae5d78c056dd41b0d7 (presubmit successful).