Track Source objects in PackageNames.

lib/src/validator/dependency.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:pub_semver/pub_semver.dart';
 
 import '../entrypoint.dart';
 import '../log.dart' as log;
 import '../package.dart';
+import '../source/hosted.dart';
+import '../source/path.dart';
 import '../validator.dart';
 
 /// The range of all pub versions that don't support `^` version constraints.
 ///
 /// This is the actual range of pub versions, whereas [_postCaretPubVersions] is
 /// the nicer-looking range that doesn't include a prerelease tag.
 final _preCaretPubVersions = new VersionConstraint.parse("<1.8.0-dev.3.0");
 
 /// The range of all pub versions that do support `^` version constraints.
 ///
 /// This is intersected with the user's SDK constraint to provide a suggested
 /// constraint.
 final _postCaretPubVersions = new VersionConstraint.parse("^1.8.0");
 
 /// A validator that validates a package's dependencies.
 class DependencyValidator extends Validator {
   /// Whether the SDK constraint guarantees that `^` version constraints are
   /// safe.
   bool get _caretAllowed => entrypoint.root.pubspec.environment.sdkVersion
       .intersect(_preCaretPubVersions).isEmpty;
 
   DependencyValidator(Entrypoint entrypoint)
     : super(entrypoint);
 
   Future validate() async {
     var caretDeps = [];
 
     for (var dependency in entrypoint.root.pubspec.dependencies) {
-      if (dependency.source != "hosted") {
+      if (dependency.source is! HostedSource) {
         await _warnAboutSource(dependency);
       } else if (dependency.constraint.isAny) {
         _warnAboutNoConstraint(dependency);
       } else if (dependency.constraint is Version) {
         _warnAboutSingleVersionConstraint(dependency);
       } else if (dependency.constraint is VersionRange) {
         if (dependency.constraint.min == null) {
           _warnAboutNoConstraintLowerBound(dependency);
         } else if (dependency.constraint.max == null) {
           _warnAboutNoConstraintUpperBound(dependency);
@@ skipping 26 matching lines @@
     if (primary != null) {
       constraint = _constraintForVersion(primary);
     } else {
       constraint = dep.constraint.toString();
       if (!dep.constraint.isAny && dep.constraint is! Version) {
         constraint = '"$constraint"';
       }
     }
 
     // Path sources are errors. Other sources are just warnings.
-    var messages = warnings;
-    if (dep.source == "path") {
-      messages = errors;
-    }
+    var messages = dep.source is PathSource ? errors : warnings;
 
     messages.add('Don\'t depend on "${dep.name}" from the ${dep.source} '
             'source. Use the hosted source instead. For example:\n'
         '\n'
         'dependencies:\n'
         '  ${dep.name}: $constraint\n'
         '\n'
         'Using the hosted source ensures that everyone can download your '
             'package\'s dependencies along with your package.');
   }
@@ skipping 105 matching lines @@
     errors.add(buffer.toString().trim());
   }
 
   /// Returns the suggested version constraint for a dependency that was tested
   /// against [version].
   String _constraintForVersion(Version version) {
     if (_caretAllowed) return "^$version";
     return '">=$version <${version.nextBreaking}"';
   }
 }