Track Source objects in PackageNames.

test/lock_file_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:pub/src/lock_file.dart';
 import 'package:pub/src/package.dart';
 import 'package:pub/src/source.dart';
 import 'package:pub/src/source_registry.dart';
 import 'package:pub/src/system_cache.dart';
 import 'package:pub_semver/pub_semver.dart';
 import 'package:test/test.dart';
 import 'package:yaml/yaml.dart';
 
 class MockSource extends Source {
   final String name = 'mock';
 
   BoundSource bind(SystemCache cache) =>
       throw new UnsupportedError("Cannot download mock packages.");
 
   PackageRef parseRef(String name, description, {String containingPath}) {
     if (!description.endsWith(' desc')) throw new FormatException('Bad');
-    return new PackageRef(name, this.name, description);
+    return new PackageRef(name, this, description);
   }
 
   PackageId parseId(String name, Version version, description) {
     if (!description.endsWith(' desc')) throw new FormatException('Bad');
-    return new PackageId(name, this.name, version, description);
+    return new PackageId(name, this, version, description);
   }
 
   bool descriptionsEqual(description1, description2) =>
       description1 == description2;
 
+  int hashDescription(description) => description.hashCode;
+
   String packageName(String description) {
     // Strip off ' desc'.
     return description.substring(0, description.length - 5);
   }
 }
 
 main() {
   var sources = new SourceRegistry();
   var mockSource = new MockSource();
   sources.register(mockSource);
@@ skipping 21 matching lines @@
     version: 2.3.4
     source: mock
     description: foo desc
 ''', sources);
 
         expect(lockFile.packages.length, equals(2));
 
         var bar = lockFile.packages['bar'];
         expect(bar.name, equals('bar'));
         expect(bar.version, equals(new Version(1, 2, 3)));
-        expect(bar.source, equals(mockSource.name));
+        expect(bar.source, equals(mockSource));
         expect(bar.description, equals('bar desc'));
 
         var foo = lockFile.packages['foo'];
         expect(foo.name, equals('foo'));
         expect(foo.version, equals(new Version(2, 3, 4)));
-        expect(foo.source, equals(mockSource.name));
+        expect(foo.source, equals(mockSource));
         expect(foo.description, equals('foo desc'));
       });
 
       test("allows an unknown source", () {
         var lockFile = new LockFile.parse('''
 packages:
   foo:
     source: bad
     version: 1.2.3
     description: foo desc
 ''', sources);
         var foo = lockFile.packages['foo'];
-        expect(foo.source, equals('bad'));
+        expect(foo.source, equals(sources['bad']));
       });
 
       test("allows an empty dependency map", () {
         var lockFile = new LockFile.parse('''
 packages:
 ''', sources);
         expect(lockFile.packages, isEmpty);
       });
 
       test("throws if the top level is not a map", () {
@@ skipping 79 matching lines @@
     version: 1.2.3
     source: mock
     description: foo desc
 ''', sources);
       });
     });
 
     test('serialize() dumps the lockfile to YAML', () {
       var lockfile = new LockFile([
         new PackageId(
-          'foo', mockSource.name, new Version.parse('1.2.3'), 'foo desc'),
-        new PackageId(
-          'bar', mockSource.name, new Version.parse('3.2.1'), 'bar desc')
-      ], sources);
+          'foo', mockSource, new Version.parse('1.2.3'), 'foo desc'),
+        new PackageId('bar', mockSource, new Version.parse('3.2.1'), 'bar desc')
+      ]);
 
       expect(loadYaml(lockfile.serialize(null)), equals({
         'sdk': 'any',
         'packages': {
           'foo': {
             'version': '1.2.3',
             'source': 'mock',
             'description': 'foo desc'
           },
           'bar': {
             'version': '3.2.1',
             'source': 'mock',
             'description': 'bar desc'
           }
         }
       }));
     });
   });
 }