Track Source objects in PackageNames.

lib/src/global_packages.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:path/path.dart' as p;
 import 'package:barback/barback.dart';
 import 'package:pub_semver/pub_semver.dart';
 
 import 'barback/asset_environment.dart';
 import 'entrypoint.dart';
 import 'exceptions.dart';
 import 'executable.dart' as exe;
 import 'io.dart';
 import 'lock_file.dart';
 import 'log.dart' as log;
 import 'package.dart';
 import 'pubspec.dart';
 import 'sdk.dart' as sdk;
 import 'solver/version_solver.dart';
 import 'source/cached.dart';
+import 'source/git.dart';
+import 'source/hosted.dart';
+import 'source/path.dart';
 import 'system_cache.dart';
 import 'utils.dart';
 
 /// Maintains the set of packages that have been globally activated.
 ///
 /// These have been hand-chosen by the user to make their executables in bin/
 /// available to the entire system. This lets them access them even when the
 /// current working directory is not inside another entrypoint package.
 ///
 /// Only one version of a given package name can be globally activated at a
@@ skipping 95 matching lines @@
 
     // Call this just to log what the current active package is, if any.
     _describeActive(name);
 
     // Write a lockfile that points to the local package.
     var fullPath = canonicalize(entrypoint.root.dir);
     var id = cache.path.source.idFor(name, entrypoint.root.version, fullPath);
 
     // TODO(rnystrom): Look in "bin" and display list of binaries that
     // user can run.
-    _writeLockFile(name, new LockFile([id], cache.sources));
+    _writeLockFile(name, new LockFile([id]));
 
     var binDir = p.join(_directory, name, 'bin');
     if (dirExists(binDir)) deleteEntry(binDir);
 
     _updateBinStubs(entrypoint.root, executables,
         overwriteBinStubs: overwriteBinStubs);
   }
 
   /// Installs the package [dep] and its dependencies into the system cache.
   Future _installInCache(PackageDep dep, List<String> executables,
@@ skipping 78 matching lines @@
     var id = lockFile.packages[package];
     log.message('Activated ${_formatPackage(id)}.');
   }
 
   /// Shows the user the currently active package with [name], if any.
   void _describeActive(String name) {
     try {
       var lockFile = new LockFile.load(_getLockFilePath(name), cache.sources);
       var id = lockFile.packages[name];
 
-      if (id.source == 'git') {
-        var url = cache.git.source.urlFromDescription(id.description);
+      var source = id.source;
+      if (source is GitSource) {
+        var url = source.urlFromDescription(id.description);
         log.message('Package ${log.bold(name)} is currently active from Git '
             'repository "${url}".');
-      } else if (id.source == 'path') {
-        var path = cache.path.source.pathFromDescription(id.description);
+      } else if (source is PathSource) {
+        var path = source.pathFromDescription(id.description);
         log.message('Package ${log.bold(name)} is currently active at path '
             '"$path".');
       } else {
         log.message('Package ${log.bold(name)} is currently active at version '
             '${log.bold(id.version)}.');
       }
     } on IOException {
       // If we couldn't read the lock file, it's not activated.
       return null;
     }
@@ skipping 51 matching lines @@
     var source = cache.source(id.source);
     var entrypoint;
     if (source is CachedSource) {
       // For cached sources, the package itself is in the cache and the
       // lockfile is the one we just loaded.
       entrypoint = new Entrypoint.inMemory(
           cache.load(id), lockFile, cache, isGlobal: true);
     } else {
       // For uncached sources (i.e. path), the ID just points to the real
       // directory for the package.
-      assert(id.source == "path");
       entrypoint = new Entrypoint(
-          cache.path.source.pathFromDescription(id.description), cache,
+          (id.source as PathSource).pathFromDescription(id.description), cache,
           isGlobal: true);
     }
 
     if (entrypoint.root.pubspec.environment.sdkVersion.allows(sdk.version)) {
       return entrypoint;
     }
 
     dataError("${log.bold(name)} ${entrypoint.root.version} doesn't support "
         "Dart ${sdk.version}.");
   }
@@ skipping 71 matching lines @@
     if (id == null) {
       throw new FormatException("Pubspec for activated package $name didn't "
           "contain an entry for itself.");
     }
 
     return id;
   }
 
   /// Returns formatted string representing the package [id].
   String _formatPackage(PackageId id) {
-    if (id.source == 'git') {
-      var url = cache.sources.git.urlFromDescription(id.description);
+    var source = id.source;
+    if (source is GitSource) {
+      var url = source.urlFromDescription(id.description);
       return '${log.bold(id.name)} ${id.version} from Git repository "$url"';
-    } else if (id.source == 'path') {
-      var path = cache.sources.path.pathFromDescription(id.description);
+    } else if (source is PathSource) {
+      var path = source.pathFromDescription(id.description);
       return '${log.bold(id.name)} ${id.version} at path "$path"';
     } else {
       return '${log.bold(id.name)} ${id.version}';
     }
   }
 
   /// Repairs any corrupted globally-activated packages and their binstubs.
   ///
   /// Returns a pair of two lists of strings. The first indicates which packages
   /// were successfully re-activated; the second indicates which failed.
@@ skipping 44 matching lines @@
               packageExecutables,
               overwriteBinStubs: true,
               snapshots: snapshots,
               suggestIfNotOnPath: false);
           successes.add(id.name);
         } catch (error, stackTrace) {
           var message = "Failed to reactivate "
               "${log.bold(p.basenameWithoutExtension(entry))}";
           if (id != null) {
             message += " ${id.version}";
-            if (id.source != "hosted") message += " from ${id.source}";
+            if (id.source is! HostedSource) message += " from ${id.source}";
           }
 
           log.error(message, error, stackTrace);
           failures.add(p.basenameWithoutExtension(entry));
 
           tryDeleteEntry(entry);
         }
       }
     }
 
@@ skipping 298 matching lines @@
   }
 
   /// Returns the value of the property named [name] in the bin stub script
   /// [source].
   String _binStubProperty(String source, String name) {
     var pattern = new RegExp(quoteRegExp(name) + r": ([a-zA-Z0-9_-]+)");
     var match = pattern.firstMatch(source);
     return match == null ? null : match[1];
   }
 }