Remove support for conflicting constructors.

Remove support for conflicting constructors.

This removes the support for constructors with the same name as members. For instance:

class Foo {
 Foo.bar();	
 static bar() {}
}

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24914

[Johnni Winther, 2013-07-11 09:49:10]

Ping

[ahe, 2013-07-11 09:50:10]

Hi Johnni,

Could you provide an example of what you're removing support for?

Cheers,
Peter

[Johnni Winther, 2013-07-11 09:56:34]

On 2013/07/11 09:50:10, ahe wrote:
> Hi Johnni,
> 
> Could you provide an example of what you're removing support for?
> 
> Cheers,
> Peter

Issue updated with example.

[ahe, 2013-07-11 10:09:41]

AWESOME!

LGTM

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/closure.dart (right):

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/closure.dart:678:
Elements.reconstructConstructorName(enclosingElement));
I suspect we could simplify this.  The name returned from this method does not
need to be unique.

Add a TODO?

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:356: static
SourceString reconstructConstructorNameSourceString(Element element) {
Can we get rid of these methods?

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1801: Element
result = localLookup(selector.name);
Awesome!!!

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1275: name =
Elements.reconstructConstructorName(function);
Add a TODO for me to get rid of this.

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right):

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:321: name =
Elements.reconstructConstructorNameSourceString(element);
Can we get rid of this?

[Johnni Winther, 2013-07-11 13:05:52]

Committed patchset #3 manually as r24914 (presubmit successful).

[Johnni Winther, 2013-07-11 13:09:18]

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/closure.dart (right):

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/closure.dart:678:
Elements.reconstructConstructorName(enclosingElement));
On 2013/07/11 10:09:42, ahe wrote:
> I suspect we could simplify this.  The name returned from this method does not
> need to be unique.
> 
> Add a TODO?

The complexity does not come from trying to compute a unique, but preserve the
existing name, which (IIRC) reflection depends upon.

Added a TODO for simplication.

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:356: static
SourceString reconstructConstructorNameSourceString(Element element) {
On 2013/07/11 10:09:42, ahe wrote:
> Can we get rid of these methods?

That requires changes to reflection. Added a TODO.

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1275: name =
Elements.reconstructConstructorName(function);
On 2013/07/11 10:09:42, ahe wrote:
> Add a TODO for me to get rid of this.

Done.

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right):

https://codereview.chromium.org/18670003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:321: name =
Elements.reconstructConstructorNameSourceString(element);
On 2013/07/11 10:09:42, ahe wrote:
> Can we get rid of this?

It requires changes to reflection. Added a TODO.

[ahe, 2013-07-11 13:51:03]

Johhni, this is good news.  In theory, reflection should not require the
reconstructConstructorName variants, but I guess in practice there are some
vestiges.  I'll see if I can get them removed.