Remove support for conflicting constructors.

sdk/lib/_internal/compiler/implementation/closure.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library closureToClassMapper;
 
 import "elements/elements.dart";
 import "dart2jslib.dart";
 import "dart_types.dart";
 import "scanner/scannerlib.dart" show Token;
@@ skipping 653 matching lines @@
     }
     for (Element enclosingElement = element.enclosingElement;
          enclosingElement != null &&
              (enclosingElement.kind == ElementKind.GENERATIVE_CONSTRUCTOR_BODY
               || enclosingElement.kind == ElementKind.GENERATIVE_CONSTRUCTOR
               || enclosingElement.kind == ElementKind.CLASS
               || enclosingElement.kind == ElementKind.FUNCTION
               || enclosingElement.kind == ElementKind.GETTER
               || enclosingElement.kind == ElementKind.SETTER);
          enclosingElement = enclosingElement.enclosingElement) {
-      SourceString surroundingName =
-          Elements.operatorNameToIdentifier(enclosingElement.name);
-      parts = parts.prepend(surroundingName.slowToString());
+      if (enclosingElement.isGenerativeConstructor() ||
+          enclosingElement.isGenerativeConstructorBody() ||
+          enclosingElement.isFactoryConstructor()) {
+        parts = parts.prepend(
+            Elements.reconstructConstructorName(enclosingElement));

[ahe, 2013/07/11 10:09:42]

I suspect we could simplify this.  The name returned from this method does not
need to be unique.

Add a TODO?

[Johnni Winther, 2013/07/11 13:09:19]

The complexity does not come from trying to compute a unique, but preserve the
existing name, which (IIRC) reflection depends upon.

Added a TODO for simplication.

+      } else {
+        SourceString surroundingName =
+            Elements.operatorNameToIdentifier(enclosingElement.name);
+        parts = parts.prepend(surroundingName.slowToString());
+      }
       // A generative constructors's parent is the class; the class name is
       // already part of the generative constructor's name.
       if (enclosingElement.kind == ElementKind.GENERATIVE_CONSTRUCTOR) break;
     }
     StringBuffer sb = new StringBuffer();
     parts.printOn(sb, '_');
     return sb.toString();
   }
 
   ClosureClassMap globalizeClosure(FunctionExpression node, Element element) {
@@ skipping 120 matching lines @@
   }
 
   visitTryStatement(TryStatement node) {
     // TODO(ngeoffray): implement finer grain state.
     bool oldInTryStatement = inTryStatement;
     inTryStatement = true;
     node.visitChildren(this);
     inTryStatement = oldInTryStatement;
   }
 }