Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: tests/compiler/dart2js/deprecated_features_test.dart

Issue 18670003: Remove support for conflicting constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tests/compiler/dart2js/find_my_name_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/deprecated_features_test.dart
diff --git a/tests/compiler/dart2js/deprecated_features_test.dart b/tests/compiler/dart2js/deprecated_features_test.dart
index 3d0a12e91c26abdf7126773364d3c6231bf3936d..f43b6ad297acfa938648d851d8cbefb2cb1d8a80 100644
--- a/tests/compiler/dart2js/deprecated_features_test.dart
+++ b/tests/compiler/dart2js/deprecated_features_test.dart
@@ -58,12 +58,7 @@ main() {
"19<part 'part.dart';>::${deprecatedMessage('missing part-of tag')}\n"
"0<>:/part.dart:info: Note: This file has no part-of tag, but it is being"
" used as a part.\n"
-
- // TODO(ahe): Should be <bar>.
- "52<Foo>::${deprecatedMessage('conflicting constructor')}\n"
-
- "72<bar>::info: This member conflicts with a constructor.\n"
- "103<()>::${deprecatedMessage('getter parameters')}\n",
+ "57<()>::${deprecatedMessage('getter parameters')}\n",
messages.toString());
}
@@ -80,14 +75,11 @@ const Map<String, String> TEST_SOURCE =
part 'part.dart';
class Foo {
- Foo.bar();
- static bar() => new Foo.bar();
get x() => null;
}
main() {
- var a = Foo.bar();
- var b = new Foo.bar();
+ var a = new Foo();
}
""",
// TODO(ahe): Why isn't this 'part.dart'? Why the leading slash?
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tests/compiler/dart2js/find_my_name_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698