Remove support for conflicting constructors.

sdk/lib/_internal/compiler/implementation/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library elements;
 
 
 import 'modelx.dart';
 import '../tree/tree.dart';
 import '../util/util.dart';
@@ skipping 335 matching lines @@
     Node selector = send.selector;
     // this().
     if (selector.isThis()) return true;
     // (o)() or foo()().
     if (element == null && selector.asIdentifier() == null) return true;
     if (element == null) return false;
     // foo() with foo a local or a parameter.
     return isLocal(element);
   }
 
-  static SourceString constructConstructorName(SourceString receiver,
-                                               SourceString selector) {
-    String r = receiver.slowToString();
-    String s = selector.slowToString();
-    return new SourceString('$r\$$s');
+  static SourceString reconstructConstructorNameSourceString(Element element) {

[ahe, 2013/07/11 10:09:42]

Can we get rid of these methods?

[Johnni Winther, 2013/07/11 13:09:19]

That requires changes to reflection. Added a TODO.

+    if (element.name == const SourceString('')) {
+      return element.getEnclosingClass().name;
+    } else {
+      return new SourceString(reconstructConstructorName(element));
+    }
   }
-
-  static SourceString deconstructConstructorName(SourceString name,
-                                                 ClassElement holder) {
-    String r = '${holder.name.slowToString()}\$';
-    String s = name.slowToString();
-    if (s.startsWith(r)) {
-      return new SourceString(s.substring(r.length));
+  
+  static String reconstructConstructorName(Element element) {
+    String className = element.getEnclosingClass().name.slowToString();
+    if (element.name == const SourceString('')) {
+      return className;
+    } else {
+      return '$className\$${element.name.slowToString()}';
     }
-    return null;
   }
 
   /**
    * Map an operator-name to a valid Dart identifier.
    *
    * For non-operator names, this metod just returns its input.
    *
    * The results returned from this method are guaranteed to be valid
    * JavaScript identifers, except it may include reserved words for
    * non-operator names.
@@ skipping 553 matching lines @@
   int get resolutionState;
   Token get beginToken;
   Token get endToken;
 
   // TODO(kasperl): Try to get rid of these.
   void set annotatedElement(Element value);
   void set resolutionState(int value);
 
   MetadataAnnotation ensureResolved(Compiler compiler);
 }