Issue 186003002: Pass in the isolate parameter to the weak persistent callback handler so that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 186003002: Pass in the isolate parameter to the weak persistent callback handler so that (Closed)

Created:
6 years, 9 months ago by siva

Modified:
6 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Pass in the isolate parameter to the weak persistent callback handler so that there is no need to access the current isolate in the callback and delete path (this code is run while a GC is in progress). See https://codereview.chromium.org/185643003/ for corresponding changes in dartium R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33282

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -57 lines)			Patch
M	runtime/bin/dartutils.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/bin/io_buffer.h	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1 2	4 chunks	+16 lines, -14 lines	0 comments	Download
M	runtime/lib/typed_data.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2	5 chunks	+14 lines, -9 lines	0 comments	Download
M	runtime/vm/dart_api_state.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/gc_marker.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/handles.h	View	1 2	1 chunk	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2	5 chunks	+15 lines, -5 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	6 chunks	+22 lines, -12 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/verifier.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

siva

6 years, 9 months ago (2014-03-04 18:11:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r33282 (presubmit successful).