Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: runtime/vm/object.h

Issue 186003002: Pass in the isolate parameter to the weak persistent callback handler so that (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 33281)
+++ runtime/vm/object.h (working copy)
@@ -2345,7 +2345,9 @@
void SetPrivateKey(const String& value) const;
static RawTokenStream* New();
- static void DataFinalizer(Dart_WeakPersistentHandle handle, void *peer);
+ static void DataFinalizer(Dart_Isolate isolate,
+ Dart_WeakPersistentHandle handle,
+ void *peer);
FINAL_HEAP_OBJECT_IMPLEMENTATION(TokenStream, Object);
friend class Class;
@@ -5288,7 +5290,9 @@
void* peer,
Dart_PeerFinalizer cback);
- static void Finalize(Dart_WeakPersistentHandle handle, void* peer);
+ static void Finalize(Dart_Isolate isolate,
+ Dart_WeakPersistentHandle handle,
+ void* peer);
static const ClassId kClassId = kOneByteStringCid;
@@ -5379,7 +5383,9 @@
void* peer,
Dart_PeerFinalizer cback);
- static void Finalize(Dart_WeakPersistentHandle handle, void* peer);
+ static void Finalize(Dart_Isolate isolate,
+ Dart_WeakPersistentHandle handle,
+ void* peer);
static RawTwoByteString* null() {
return reinterpret_cast<RawTwoByteString*>(Object::null());
@@ -5472,7 +5478,9 @@
raw_ptr(str)->external_data_ = data;
}
- static void Finalize(Dart_WeakPersistentHandle handle, void* peer);
+ static void Finalize(Dart_Isolate isolate,
+ Dart_WeakPersistentHandle handle,
+ void* peer);
static RawExternalOneByteString* ReadFrom(SnapshotReader* reader,
intptr_t object_id,
@@ -5543,7 +5551,9 @@
raw_ptr(str)->external_data_ = data;
}
- static void Finalize(Dart_WeakPersistentHandle handle, void* peer);
+ static void Finalize(Dart_Isolate isolate,
+ Dart_WeakPersistentHandle handle,
+ void* peer);
static RawExternalTwoByteString* ReadFrom(SnapshotReader* reader,
intptr_t object_id,
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698