runtime/vm/dart_api_state.h - Issue 186003002: Pass in the isolate parameter to the weak persistent callback handler so that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_state.h

Issue 186003002: Pass in the isolate parameter to the weak persistent callback handler so that (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_state.h

===================================================================

--- runtime/vm/dart_api_state.h (revision 33281)

+++ runtime/vm/dart_api_state.h (working copy)

@@ -217,7 +217,8 @@

return (addr & kWeakPersistentTagMask) == kPrologueWeakPersistentTag;

}

static FinalizablePersistentHandle* Cast(Dart_WeakPersistentHandle handle);

- static void Finalize(FinalizablePersistentHandle* handle,

+ static void Finalize(Isolate* isolate,

+ FinalizablePersistentHandle* handle,

bool is_prologue_weak) {

Dart_WeakPersistentHandleFinalizer callback = handle->callback();

if (callback != NULL) {

@@ -226,7 +227,7 @@

Dart_WeakPersistentHandle object = is_prologue_weak ?

handle->apiPrologueHandle() :

handle->apiHandle();

- (*callback)(object, peer);

+ (*callback)(reinterpret_cast<Dart_Isolate>(isolate), object, peer);

} else {

handle->Clear();

}

« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/gc_marker.cc » ('j') | no next file with comments »