runtime/vm/dart_api_impl.cc - Issue 186003002: Pass in the isolate parameter to the weak persistent callback handler so that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 186003002: Pass in the isolate parameter to the weak persistent callback handler so that (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

===================================================================

--- runtime/vm/dart_api_impl.cc (revision 33281)

+++ runtime/vm/dart_api_impl.cc (working copy)

@@ -674,9 +674,11 @@

DART_EXPORT void Dart_DeleteWeakPersistentHandle(

+ Dart_Isolate current_isolate,

Dart_WeakPersistentHandle object) {

- Isolate* isolate = Isolate::Current();

+ Isolate* isolate = reinterpret_cast<Isolate*>(current_isolate);

CHECK_ISOLATE(isolate);

+ ASSERT(isolate == Isolate::Current());

ApiState* state = isolate->api_state();

ASSERT(state != NULL);

if (FinalizablePersistentHandle::IsPrologueWeakPersistentHandle(object)) {

« no previous file with comments | « runtime/lib/typed_data.cc ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »