Fix type checks with malformed types

Fix type checks with malformed types

Parser must continue to parse the rest of an expression that contains
a type test with a malformed type.

Before:
'file:XXX’: error: line 5 pos 12: ')' expected
  if (3 is X && 2 == 2) print("foo");

After:
'file:XXX’: malformed type: line 5 pos 12: type 'X' is not loaded
  if (3 is X && 2 == 2) print("foo");
           ^
type error.
#0      main (file:XXX:5:12)
#1      _startIsolate.isolateStartHandler (dart:isolate-patch/isolate_patch.dart:216)
#2      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:115)

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33253

[regis, 2014-03-03 21:26:38]

LGTM

No test?

[hausner, 2014-03-03 23:26:00]

Figuring out the test harness is more challenging than fixing the compiler bug.
But here you go.

[hausner, 2014-03-03 23:27:49]

Committed patchset #3 manually as r33253 (presubmit successful).

[Florian Schneider, 2014-03-04 09:48:24]

https://codereview.chromium.org/183743015/diff/40001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/183743015/diff/40001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:7615: left_operand = ThrowTypeError(type_pos, type);
I think you can use LetNode as a light-weight sequence of nodes here. Something
like this may work:

AstNode* node = new LetNode(left_operand_pos);
node->AddNode(left_operand);
node->AddNode(ThrowTypeError(type_pos, type));
left_operand = node;
break;

[hausner, 2014-03-04 21:06:36]

Thank you for the tip, Florian. Addressed in follow-up change
https://codereview.chromium.org/185553018/