Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: runtime/vm/parser.cc

Issue 183743015: Fix type checks with malformed types (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/is_malformed_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 33231)
+++ runtime/vm/parser.cc (working copy)
@@ -7610,7 +7610,10 @@
type.IsMalformedOrMalbounded()) {
// Note that a type error is thrown even if the tested value is null
// in a type test or in a type cast.
- return ThrowTypeError(type_pos, type);
+ // TODO(hausner): We drop the left operand. We need to
+ // evaluate it in case there are side effects.
+ left_operand = ThrowTypeError(type_pos, type);
Florian Schneider 2014/03/04 09:48:24 I think you can use LetNode as a light-weight sequ
+ break; // Type checks and casts can't be chained.
}
}
if (Token::IsRelationalOperator(op_kind)
« no previous file with comments | « no previous file | tests/language/is_malformed_type_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698