Fix type checks with malformed types

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "lib/invocation_mirror.h"
 #include "platform/utils.h"
 #include "vm/bootstrap.h"
 #include "vm/class_finalizer.h"
@@ skipping 7592 matching lines @@
           CaptureInstantiator();
         }
         right_operand = new TypeNode(type_pos, type);
         // In production mode, the type may be malformed.
         // In checked mode, the type may be malformed or malbounded.
         if (((op_kind == Token::kIS) || (op_kind == Token::kISNOT) ||
              (op_kind == Token::kAS)) &&
             type.IsMalformedOrMalbounded()) {
           // Note that a type error is thrown even if the tested value is null
           // in a type test or in a type cast.
-          return ThrowTypeError(type_pos, type);
+          // TODO(hausner): We drop the left operand. We need to
+          // evaluate it in case there are side effects.
+          left_operand = ThrowTypeError(type_pos, type);

[Florian Schneider, 2014/03/04 09:48:24]

I think you can use LetNode as a light-weight sequence of nodes here. Something
like this may work:

AstNode* node = new LetNode(left_operand_pos);
node->AddNode(left_operand);
node->AddNode(ThrowTypeError(type_pos, type));
left_operand = node;
break;

+          break;  // Type checks and casts can't be chained.
         }
       }
       if (Token::IsRelationalOperator(op_kind)
           || Token::IsTypeTestOperator(op_kind)
           || Token::IsTypeCastOperator(op_kind)
           || Token::IsEqualityOperator(op_kind)) {
         if (Token::IsTypeTestOperator(op_kind) ||
             Token::IsTypeCastOperator(op_kind)) {
           if (!right_operand->AsTypeNode()->type().IsInstantiated()) {
             EnsureExpressionTemp();
@@ skipping 3162 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart