Issue 185553018: Always evaluate e in (e is T)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185553018: Always evaluate e in (e is T) (Closed)

Created:
6 years, 9 months ago by hausner

Modified:
6 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Always evaluate e in (e is T) (e is T) is compiled to a throw TypeError when T is malformed. This change makes sure that e is evaluated even though it is ignored. We need to do this due to possible side effects. Fixes issue 17253 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=33299

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	runtime/vm/parser.cc	View		1 chunk	+8 lines, -5 lines	0 comments	Download
	M	tests/language/language.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

6 years, 9 months ago (2014-03-04 20:44:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33299 (presubmit successful).

Expand Messages | Collapse Messages