Correct handling of named optional parameters with noSuchMethod invocations.

Correct handling of named optional parameters with noSuchMethod invocations.

This CL fixes a performance bug with noSuchMethod and named parameters. It also
simplifies the platform-specific code by removing special casing for the
noSuchMethod-dispatcher functions in the flow graph compiler.

Before using named optional parameters would still go through the slow
runtime in certain conditions: When running without inlining, or when
the dispatcher function was not inlined because of e.g. inlining size
heuristics, noSuchMethod would be slow if invoked with named parameters.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24906

[srdjan, 2013-07-10 23:29:04]

lgtm

https://codereview.chromium.org/18209024/diff/1/runtime/vm/dart_entry.cc
File runtime/vm/dart_entry.cc (right):

https://codereview.chromium.org/18209024/diff/1/runtime/vm/dart_entry.cc#newc...
runtime/vm/dart_entry.cc:185: return array_.At(offset) == other.raw();
Reuse NameAt here

[Florian Schneider, 2013-07-11 09:21:23]

https://codereview.chromium.org/18209024/diff/1/runtime/vm/dart_entry.cc
File runtime/vm/dart_entry.cc (right):

https://codereview.chromium.org/18209024/diff/1/runtime/vm/dart_entry.cc#newc...
runtime/vm/dart_entry.cc:185: return array_.At(offset) == other.raw();
On 2013/07/10 23:29:04, srdjan wrote:
> Reuse NameAt here

Done.

[Florian Schneider, 2013-07-11 10:01:58]

Committed patchset #2 manually as r24906 (presubmit successful).