runtime/vm/flow_graph_compiler_arm.cc - Issue 18209024: Correct handling of named optional parameters with noSuchMethod invocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 18209024: Correct handling of named optional parameters with noSuchMethod invocations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: addressed comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_arm.cc

===================================================================

--- runtime/vm/flow_graph_compiler_arm.cc (revision 24876)

+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)

@@ -1125,8 +1125,7 @@

ASSERT(!parsed_function().function().HasOptionalParameters());

const bool check_arguments = true;

#else

- const bool check_arguments =

- function.IsClosureFunction() || function.IsNoSuchMethodDispatcher();

+ const bool check_arguments = function.IsClosureFunction();

#endif

if (check_arguments) {

__ Comment("Check argument count");

@@ -1140,7 +1139,7 @@

__ cmp(R0, ShifterOperand(R1));

__ b(&correct_num_arguments, EQ);

__ Bind(&wrong_num_arguments);

- if (function.IsClosureFunction() || function.IsNoSuchMethodDispatcher()) {

+ if (function.IsClosureFunction()) {

// Invoke noSuchMethod function passing the original function name.

// For closure functions, use "call" as the original name.

const String& name =

« no previous file with comments | « runtime/vm/dart_entry.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »